-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pandas and xarray methods to dataset.cache matching the dataset #2763
Merged
jenshnielsen
merged 19 commits into
microsoft:master
from
jenshnielsen:dataset_cache_align_with_ds
Feb 24, 2021
Merged
Add pandas and xarray methods to dataset.cache matching the dataset #2763
jenshnielsen
merged 19 commits into
microsoft:master
from
jenshnielsen:dataset_cache_align_with_ds
Feb 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2763 +/- ##
==========================================
+ Coverage 63.84% 63.88% +0.03%
==========================================
Files 199 199
Lines 26493 26516 +23
==========================================
+ Hits 16915 16939 +24
+ Misses 9578 9577 -1 |
trevormorgan
approved these changes
Feb 23, 2021
astafan8
changed the title
Add pandas and xarray methods to dataset.cache mathcing the dataset
Add pandas and xarray methods to dataset.cache matching the dataset, and minimal tests
Feb 23, 2021
@jenshnielsen ended up adding one test with parametrization per export format only for 2D data. Feel free to adjust as needed to save some test execution time. some of them are failing, sorry, didn't have time to dig into why |
jenshnielsen
force-pushed
the
dataset_cache_align_with_ds
branch
2 times, most recently
from
February 24, 2021 08:41
00f4bb3
to
bcc9f52
Compare
jenshnielsen
force-pushed
the
dataset_cache_align_with_ds
branch
from
February 24, 2021 08:45
bcc9f52
to
7aeaaa8
Compare
jenshnielsen
changed the title
Add pandas and xarray methods to dataset.cache matching the dataset, and minimal tests
Add pandas and xarray methods to dataset.cache matching the dataset
Feb 24, 2021
astafan8
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests to be done via #2771