Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pandas and xarray methods to dataset.cache matching the dataset #2763

Merged

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Feb 22, 2021

Tests to be done via #2771

@jenshnielsen jenshnielsen added this to the 0.23.0 milestone Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #2763 (556ce04) into master (fcefc8f) will increase coverage by 0.03%.
The diff coverage is 84.09%.

@@            Coverage Diff             @@
##           master    #2763      +/-   ##
==========================================
+ Coverage   63.84%   63.88%   +0.03%     
==========================================
  Files         199      199              
  Lines       26493    26516      +23     
==========================================
+ Hits        16915    16939      +24     
+ Misses       9578     9577       -1     

@astafan8 astafan8 changed the title Add pandas and xarray methods to dataset.cache mathcing the dataset Add pandas and xarray methods to dataset.cache matching the dataset, and minimal tests Feb 23, 2021
@astafan8
Copy link
Contributor

Update and improve tests

@jenshnielsen ended up adding one test with parametrization per export format only for 2D data. Feel free to adjust as needed to save some test execution time. some of them are failing, sorry, didn't have time to dig into why

@jenshnielsen jenshnielsen force-pushed the dataset_cache_align_with_ds branch 2 times, most recently from 00f4bb3 to bcc9f52 Compare February 24, 2021 08:41
@jenshnielsen jenshnielsen changed the title Add pandas and xarray methods to dataset.cache matching the dataset, and minimal tests Add pandas and xarray methods to dataset.cache matching the dataset Feb 24, 2021
@jenshnielsen jenshnielsen merged commit 50172d9 into microsoft:master Feb 24, 2021
@jenshnielsen jenshnielsen deleted the dataset_cache_align_with_ds branch February 24, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants