MAINT: Consolidate regex scorer defaults - #2351
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
Conversation
Move shared configurable and fixed constructor behavior into declarative regex scorer defaults while preserving public signatures and overrides. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The public regex scorer subclasses repeat the same pass-through constructor logic for selecting default patterns, categories, and score aggregation. This change centralizes that behavior in
RegexScorerthrough private constructor mixins and declarative class defaults.The refactor preserves the existing public API and behavior: configurable scorers retain
patternsandscore_aggregator, fixed keyword scorers retain zero-argument construction, andStaticPromptInjectionScorerkeeps its distinctcategoriesoverride. Pattern order, per-instance copies, custom replacements, exported names, identifiers, and subclass semantics remain unchanged. Fifteen duplicated constructor bodies are removed, reducing production code by a net 243 lines.Tests and Documentation
Added focused regression coverage for public constructor signatures, default pattern content and order, copy semantics, categories, custom pattern and aggregator overrides, exports, subclass identity, and identifier JSON round-tripping.
Ruff format/check, targeted
ty, compile checks,git diff --check, and isolated runtime contract checks across all 15 affected subclasses passed. The comprehensive regex pytest suite could not start in this worktree because its empty.venvcould not be restored:uv sync --offlinefirst lacked cachedty==0.0.65, while online synchronization repeatedly failed TLS handshakes againstfiles.pythonhosted.org. Documentation was not changed because this is behavior-preserving.