FIX Avoid poisoned dataset ZIP caches - #2345
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Interrupted streamed ZIP downloads were written directly to the final dataset cache path. A transient connection failure could therefore leave a partial archive that every later call treated as a cache hit, preventing recovery without manual cache cleanup.
This change downloads into a unique temporary file in the cache directory, parses the archive successfully, and only then atomically publishes it to the final cache path. Failed downloads and parses clean up the temporary file so a later call can redownload normally.
Tests and Documentation
Added a deterministic unit test that simulates a partial chunk followed by a connection failure, verifies no poisoned cache remains, then retries successfully and checks the exact network-call and cache-file behavior.
git diff --checkpassed