FIX Handle attack parameter construction failures - #2344
Open
Roman Lutz (romanlutz) wants to merge 1 commit into
Open
FIX Handle attack parameter construction failures#2344Roman Lutz (romanlutz) wants to merge 1 commit into
Roman Lutz (romanlutz) wants to merge 1 commit into
Conversation
Settle parameter construction failures deterministically, preserve original input alignment, and execute successful builds in partial mode so scenario resume can avoid duplicate materialization. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b3468bc-0737-461b-bb82-18dad97d400e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parameter construction for multi-objective attacks previously used fail-fast gathering, even when
return_partial_on_failure=True. A simulated-conversation build could already perform model calls and persist memory state before a sibling failed, after which no successfully built objective executed and Scenario retry regenerated that work.This change makes parameter construction follow the executor's existing failure contract:
BaseExceptionvalues continue to propagate.Tests and Documentation
Added deterministic event-controlled tests for out-of-order build failures, mixed build/execution failures, strict suppression, cancellation propagation, original input-index alignment, and real Strategy-to-AtomicAttack-to-Scenario-to-CentralMemory retry linkage.
Validation:
typassed for all changed files.Documentation was not changed because this fixes the existing
return_partial_on_failurecontract without adding a new public API. JupyText was not applicable.