restricting logs, output to appdata local directory for write operations #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snamilikonda
commented
Nov 21, 2024
|
|
||
| public bool IsValidFilePath(string filePath) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(filePath)) | ||
| return false; |
There was a problem hiding this comment.
additional considerations here on what is valid
snamilikonda
commented
Nov 22, 2024
| /// Wrapper for any System.IO methods needed | ||
| /// </summary> | ||
| [Export(typeof(IFileSystem))] | ||
| public class FileSystem : IFileSystem |
There was a problem hiding this comment.
add an allowlist and denylist regexes to restrict where files can be read from
by default allow everything and deny nothing. users can allow or deny what they want.
input taken testsetting at highest level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist