Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Builder: fix config access, add UT, clean up CI yamls #1638

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Feb 21, 2025

Describe your changes

  • Fix config access in model builder pass
  • Add unit test for model builder. CPU tests now has its own requirements file.
  • Do some clean up in the pipeline yamls:
    • set gpu defaults in gpu test templates
    • removed unused device template parameters
    • remove redundant parameter assignment from template calls
    • nightly gpu test uses gpu image

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Fixes #1635

@jambayk jambayk merged commit 0c7ff92 into main Feb 21, 2025
24 checks passed
@jambayk jambayk deleted the jambayk/mb-fix branch February 21, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to use olive on SmolLM2-135M-Instruct with lora adapter
2 participants