Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add BAAI/bge-small-en-v1.5 Optimization #1634
base: main
Are you sure you want to change the base?
add BAAI/bge-small-en-v1.5 Optimization #1634
Changes from 16 commits
9fdba1a
f6fdc65
d587239
b7c555d
72f3ef4
bece557
4bcea27
87dc670
bf8c5ac
69fbd76
e9ab69d
f2b6304
c09c457
bad50c0
0995c8d
93ae4c4
cc6209b
01fe1a5
35df18e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a dev branch where I introduce an option called op_type_to_exclude which is used to modify op_types_to_quantize and nodes_to_exclude.
Olive/olive/passes/onnx/quantization.py
Line 57 in 6e5c3b4
Looks like it might be useful here too when it gets merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise, we need to know all of the op types present in the model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently use append_first_op_types_to_quantize_list with nodes_to_exclude will do this. Will we also update this logic?
Olive/olive/passes/onnx/quantization.py
Line 409 in 043f7e1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly, I am not sure why this option was added and if it is used for anything right now.
Not sure if we will touch this option and related logic but I plan to update the logic to be able to use
op_types_to_exclude
andnodes_to_exclude
. Theop_types_to_exclude
has been very useful for me when I know I don't want to quantize all nodes for an op.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also created this PR in ort microsoft/onnxruntime#23779.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could merge following the clip?