-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dynamo exporter] Support string in dynamic_shapes #1631
Closed
titaiwangms
wants to merge
7
commits into
microsoft:main
from
titaiwangms:titaiwang/support_custom-axis
Closed
[dynamo exporter] Support string in dynamic_shapes #1631
titaiwangms
wants to merge
7
commits into
microsoft:main
from
titaiwangms:titaiwang/support_custom-axis
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some CI tests are failing with |
jambayk
reviewed
Feb 20, 2025
jambayk
reviewed
Feb 21, 2025
jambayk
reviewed
Feb 21, 2025
Replaced by #1639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
With pytorch/pytorch#146321,
torch.onnx.export(.., dynamo=True)
now can support string in dynamic_shapes, which fits better with Olive driven with configuration.Major changes:
torch.onn.export(..., dynamo=True)
can now take string.Pitfall:
Minor changes:
Checklist before requesting a review
lintrunner -a
(Optional) Issue link