Made bounds control more overridable #11819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HossamBasion
requested review from
marlenaklein-msft,
AMollis and
shaynie
as code owners
| @@ -530,7 +530,7 @@ private void Awake() | |||
| } | |||
| } | |||
|
|
|||
| private void Update() | |||
| public virtual void Update() | |||
There was a problem hiding this comment.
suggest to make these protected virtual so we aren't allowing outside classes to call them manually
|
@HossamBasion it looks like this PR is targeting MRTK3, so it should probably go into the new repo at https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Made four functions in BoundControl.cs public virtual instead of private and internal