Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRKT3] Making custom reticles a bit easier in MRTK3. #11758

Merged
merged 3 commits into from
Aug 4, 2023
Merged

[MRKT3] Making custom reticles a bit easier in MRTK3. #11758

merged 3 commits into from
Aug 4, 2023

Commits on Aug 3, 2023

  1. The intent of this change is to make attaching a custom reticle easie… 

    …r in MRTK. The custom reticle is now attached to the base recticle's root transform, removing the need for the custom reticle to position itself.

Also, reverting changes made to `RecticleMagnetism`, this now is using an interface again for setting progress, instead of requiring a RingReticle component.  Instead of using the old `IVariableReticle` its not `IVariableProgressReticle` to better indicate the propose of the interface.

I also rename the newer `IVariableReticle`  to `RecticleVisual` to better indicate its purpose.
    @AMollis
    AMollis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    435925d View commit details
    Browse the repository at this point in the history

  2. Updating comments

    @AMollis
    AMollis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    015091c View commit details
    Browse the repository at this point in the history

  3. Comment update

    @AMollis
    AMollis committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    97afa31 View commit details
    Browse the repository at this point in the history