-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BoundsControlRuntimeExamples Sample Scene #11687
Closed
drusk-unity
wants to merge
127
commits into
microsoft:mrtk3
from
drusk-unity:MRH3-24-BoundsControlRuntimeExamples
Closed
BoundsControlRuntimeExamples Sample Scene #11687
drusk-unity
wants to merge
127
commits into
microsoft:mrtk3
from
drusk-unity:MRH3-24-BoundsControlRuntimeExamples
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed scripts from MRTK2 version which are not needed to demonstrate this functionality.
The previous material would turn black on one side depending what angle you looked at it from.
Using MRTKLineVisual and BezierDataProvider. Note that the MRTK2 version of the LineExamples sample scene had more examples because more data providers were implemented. Additionally, the MRTKLineVisual ties the lines to an Interactor, unlike the MRTK2 scripts.
…mand to reset the experience
… font size of dialog panels larger.
MRH3-15 DwellExample
- Refactoring the visualizer sample scene - Removed InputPointerVisualizer which was unused in the sample - Removed InputPointerVisualer code from UserInputPlayback - Moved the inheritance base file logging functionality of UserInputRecorder into FileInputLogger
- Removed InputPointerVisualizer, ParticleHeatmap, and ParticleHeapmapParticleData Co-authored-by: Amelia Mesdag <[email protected]>
- Added Pause/Resume functionality - Add documentation to eye gaze visualizer classes
- Remove unreferenced function - Add documentation - Fix audio source references for object selection and deselection in Target Positioning scene - Update function visibility
- Add DisableOnStart script for dialog that needed to be disabled at runtime - Add documentation for PanZoom StatefulInteractables
- Removed creation of a subfolder in FileInputLogger - Note: MusicLibrary permission needs to be granted in PlayerSettings
- Removed duplicate EyeCalibrationChecker
…ple-Feedback MRH3-62 Eye Tracking Examples Feedback
Changing the name allowed removing "Demos" from the namespace (otherwise it conflicted with the script in the EyeTracking folder).
Had to update a number of prefabs and a scene in order to avoid using the FormerlySerializedAs attribute.
Miscellaneous feedback
drusk-unity
requested review from
marlenaklein-msft,
AMollis and
shaynie
as code owners
July 7, 2023 08:43
@drusk-unity thank you! We've committed these changes and more with the following. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Porting
BoundsControlRuntimeExamples
scene to MRTK3. This PR contains the work from #11647 so should be merged afterwards.Changes
#11511