Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing <summary> tag documentation to public MRTK3 classes and members #11614

Merged
merged 9 commits into from
Jun 10, 2023

Conversation

AMollis
Copy link
Member

@AMollis AMollis commented Jun 9, 2023

Overview

Adding in some missing documentation to the MRTK3 source.

This also replaces some ref parameters with in parameters, in cases where it was obvious that only "const refs" were needed. This also removed the InterpolationType.Hermite since it was never handled or used.

The following were documentated:

  • CameraSettings class
  • LabelWidthAttribute class
  • MathExtensions.PowerOfTwoGreate=rThanOrEqualTo
  • MathExtensions.CubicToLinearIndex
  • MathExtensions.LinearToCubicIndex
  • MathExtensions.ClampComponentWise
  • RayStep struct and some functions
  • StatefulInteractable class
  • SystemInterfaceType constructors
  • SystemType public functions
  • TimedFlag class definition
  • UXBindingProfileTemplate properties
  • VectorExtensions some functions
  • TextToSpeechSubsystem.Provider class definition
  • BezierInertia class definition, serialized field tooltips
  • FuzzyGazeInteractor.GazeRaycastHitResult struct definition and public members
  • HandJointInteractor public method
  • HandshapeTypes class definition
  • InputActionPoseSource serialized field tooltips.
  • InteractionMode struct definition and serialized field tooltips and properties
  • InteractionModeDefinition serialized field tooltips and properties
  • InteractionModeManager public method
  • InterpolationType enum values
  • MRTKHandsAggregatorSubsystem.MRTKAggregator class definition and public members

Bugs

@AMollis
Copy link
Member Author

AMollis commented Jun 9, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AMollis AMollis merged commit 875c1ad into microsoft:mrtk3 Jun 10, 2023
@AMollis AMollis deleted the user/amollis/mrtk3/adding-summaries branch June 10, 2023 18:12
drusk-unity pushed a commit to drusk-unity/MixedRealityToolkit-Unity that referenced this pull request Jun 26, 2023
…11614)

Adding in some missing documentation to the MRTK3 source.  

This also replaces some `ref` parameters with `in` parameters, in cases where it was obvious that only "const refs" were needed.  This also removed the `InterpolationType.Hermite` since it was never handled or used.

The following were documentated:
  - [x] `CameraSettings` class
  - [x] `LabelWidthAttribute` class
  - [x] `MathExtensions.PowerOfTwoGreate=rThanOrEqualTo`
  - [x] `MathExtensions.CubicToLinearIndex`
  - [x] `MathExtensions.LinearToCubicIndex`
  - [x] `MathExtensions.ClampComponentWise`
  - [x] `RayStep` struct and some functions
  - [x] `StatefulInteractable` class
  - [x] `SystemInterfaceType` constructors
  - [x] `SystemType` public functions
  - [x] `TimedFlag` class definition
  - [x] `UXBindingProfileTemplate` properties
  - [x] `VectorExtensions` some functions
  - [x] `TextToSpeechSubsystem.Provider` class definition
  - [x] `BezierInertia` class definition, serialized field tooltips
  - [x] `FuzzyGazeInteractor.GazeRaycastHitResult` struct definition and public members
  - [x] `HandJointInteractor` public method
  - [x] `HandshapeTypes` class definition
  - [x] `InputActionPoseSource` serialized field tooltips.
  - [x] `InteractionMode` struct definition and serialized field tooltips and properties
  - [x] `InteractionModeDefinition` serialized field tooltips and properties
  - [x] `InteractionModeManager` public method
  - [x] `InterpolationType` enum values
  - [x] `MRTKHandsAggregatorSubsystem.MRTKAggregator` class definition and public members

## Bugs
- microsoft#11596
- microsoft#1159
@AMollis AMollis changed the title Adding in some missing documentation to the MRTK3 source. Added missing <summary> tag documentation to public MRTK3 classes and members Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants