-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to ConfigSpace 1.* #802
Conversation
…ed to remove them
…/opt/configspace-1.0
That ConfigSpace update to SMAC was merged, but they haven't cut a new version for us to pull in yet. |
mlos_core/mlos_core/optimizers/bayesian_optimizers/smac_optimizer.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just would like to get that quantization support back in asap.
Main remaining question is around the param.to_vector(param.to_vector(...))
transformation. Didn't quite look right, but maybe I'm missing something?
unit tests seem to break because of #826 - checking it now |
cc67ece
to
96ad677
Compare
Splitting out from #802 to benefit other jobs as well.
This PR enables Python 3.12 in Windows environment and does not restrict Python version in the default environments on Windows and Linux. Note that although `mlos-3.12.yml` exists, its usage is still commented out in `linux.yml`, because Python 3.12 is still not available on GitHub CI. Issue #832 opened to track it P.S. Also, we now use a lighter `matplotlib-base` instead of `matplotlib` proper ~To be merged after #802~ --------- Co-authored-by: Brian Kroth <[email protected]>
Summary of changes:
Notes:
Supersedes Bump configspace from 0.7.1 to 1.0.1 in /mlos_core #799Depends on upcoming SMAC3 release with SMAC3 #1124 merged in and a new release cut with it.Tests fail due to LlamaTune issue:Closes #727