Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple function calls in Chapter 5 #739

Merged
merged 3 commits into from
May 31, 2024

Conversation

mfruhner
Copy link
Contributor

@mfruhner mfruhner commented May 27, 2024

Hello,

there are currently two problems with the README of 5.1:

df.corr
The default value of df.corr()'s numeric_only parameter changed to False in 2.0.
Therefore the code in the notebook throws an error when executed.
I set the parameter back to True, which fixes the notebook.

sns.FacetGrid
The name of the size parameter has changed to height.
I fixed that as well.

There is also a change in the handling of sns color palettes, where you now have to assign the hue parameter to x, but I did not include that change, yet. Let me know, if you would like me to add it.

In the README of 5.2, the sns.lineplot function does not accept 2 positional arguments (anymore). I named them x and y accordingly.

Best regards,
Maik

@mfruhner mfruhner changed the title Fix 5-1 df.corr() call to match 2.0 default parameters Fix 5-1 df.corr() call to match pandas 2.0 default parameters May 27, 2024
@mfruhner mfruhner changed the title Fix 5-1 df.corr() call to match pandas 2.0 default parameters Fix 5-1 pandas and sns calls May 27, 2024
@mfruhner
Copy link
Contributor Author

@microsoft-github-policy-service agree company="University of Applied Sciences Osnabrueck"

@mfruhner mfruhner changed the title Fix 5-1 pandas and sns calls Fix multiple function calls in Chapter 5 May 29, 2024
@BethanyJep BethanyJep merged commit 91ee7b6 into microsoft:main May 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants