[python-package] simplify scikit-learn 1.6+ tags support #6735
+11
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
commented
Dec 3, 2024
| tags.estimator_type = "regressor" | ||
| tags.regressor_tags = _sklearn_RegressorTags(multi_label=False) | ||
| return tags | ||
| return super().__sklearn_tags__() |
There was a problem hiding this comment.
This is necessary even though it doesn't do anything, because of this check in scikit-learn:
E TypeError: Estimator LGBMRegressor has defined either
_more_tagsor_get_tags, but not__sklearn_tags__. If you're customizing tags, and need to support multiple scikit-learn versions, you can implement both__sklearn_tags__and_more_tagsor_get_tags. This change was introduced in scikit-learn=1.6
Added in scikit-learn/scikit-learn#30268
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
StrikerRUS
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6718
In that PR, I'd skipped the method resolution order ("MRO") for
__sklearn_tags__()in thescikit-learnestimators, to provide compatibility with earlier versions of that library. During development, we switched to having e.g.LGBMClassifier.__sklearn_tags__()raise anAttributeErrorif run on a too-new version ofscikit-learn, making that unnecessary... but never went back to just using inheritance to get__sklearn_tags__().This fixes that.
Notes for Reviewers
Inspired by dmlc/xgboost#11021 (comment)