Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "target es2021 (#23307)" (#23567)" #23673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "Revert "target es2021 (#23307)" (#23567)" #23673

wants to merge 1 commit into from

Conversation

CraigMacomber
Copy link
Contributor

@CraigMacomber CraigMacomber commented Jan 28, 2025 •
edited
Loading

Description

This reverts commit 08aef9c.

Reverts 23567, restoring #23307

Target es2021.

A customer issue forced us to temporarily revert the initial changes, but that issue has since been resolved.

Reviewer Guidance

The review process is outlined on this wiki page.

@Copilot Copilot bot review requested due to automatic review settings January 28, 2025 19:50
@CraigMacomber CraigMacomber requested review from a team as code owners January 28, 2025 19:50
@github-actions github-actions bot added area: build Build related issues changeset-present public api change Changes to a public API base: main PRs targeted against main branch labels Jan 28, 2025
@CraigMacomber CraigMacomber mentioned this pull request Jan 28, 2025
Closed
@github-actions GitHub Actions
Copy link
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> [email protected] ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> [email protected] serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> [email protected] check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  169324 links
    1609 destination URLs
    1841 URLs ignored
       0 warnings
       0 errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area: build Build related issues base: main PRs targeted against main branch changeset-present public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CraigMacomber