Fix /analyze warning (#261)

microsoft · Sep 27, 2024 · 24df3a1 · 24df3a1
1 parent 5b86313
commit 24df3a1
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/Src/ScreenGrab.cpp b/Src/ScreenGrab.cpp
@@ -177,7 +177,14 @@ namespace
             nullptr,
             IID_GRAPHICS_PPV_ARGS(pStaging));
         if (FAILED(hr))
+        {
+            if (*pStaging)
+            {
+                (*pStaging)->Release();
+                *pStaging = nullptr;
+            }
             return hr;
+        }
 
         SetDebugObjectName(*pStaging, L"ScreenGrab staging");
 
@@ -205,15 +212,23 @@ namespace
 
         hr = commandList->Close();
         if (FAILED(hr))
+        {
+            (*pStaging)->Release();
+            *pStaging = nullptr;
             return hr;
+        }
 
         // Execute the command list
         pCommandQ->ExecuteCommandLists(1, CommandListCast(commandList.GetAddressOf()));
 
         // Signal the fence
         hr = pCommandQ->Signal(fence.Get(), 1);
         if (FAILED(hr))
+        {
+            (*pStaging)->Release();
+            *pStaging = nullptr;
             return hr;
+        }
 
         // Block until the copy is complete
         while (fence->GetCompletedValue() < 1)