Skip to content

ValidationTest::WrongPSVVersion: use fixed validator version 1.8 #8522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tex3d wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −5
Open

ValidationTest::WrongPSVVersion: use fixed validator version 1.8 #8522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tools/clang/unittests/HLSL/ValidationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6658,12 +6658,14 @@ TEST_F(ValidationTest, WrongPSVVersion) {

CComPtr<IDxcBlob> pProgram68;

CompileFile(L"..\\DXC\\dumpPSV_CS.hlsl", "cs_6_8", &pProgram68);
LPCWSTR Args_1_8[] = {L"-validator-version", L"1.8"};
CompileFile(L"..\\DXC\\dumpPSV_CS.hlsl", "cs_6_8", Args_1_8,
_countof(Args_1_8), &pProgram68);
CComPtr<IDxcOperationResult> pResult2;
VERIFY_SUCCEEDED(pValidator->Validate(pProgram68, Flags, &pResult2));
// Make sure the validation was successful.
VERIFY_IS_NOT_NULL(pResult);
VERIFY_SUCCEEDED(pResult->GetStatus(&status));
VERIFY_IS_NOT_NULL(pResult2);
VERIFY_SUCCEEDED(pResult2->GetStatus(&status));
VERIFY_SUCCEEDED(status);

hlsl::DxilContainerHeader *pHeader68;
Expand Down Expand Up @@ -6794,7 +6796,7 @@ TEST_F(ValidationTest, WrongPSVVersion) {
CheckOperationResultMsgs(
p60WithPSV68Result,
{"DXIL container mismatch for 'PSVRuntimeInfoSize' between 'PSV0' "
"part:('56') and DXIL module:('24')"},
"part:('52') and DXIL module:('24')"},
/*maySucceedAnyway*/ false, /*bRegex*/ false);

// Create a new Blob.
Expand All @@ -6812,6 +6814,6 @@ TEST_F(ValidationTest, WrongPSVVersion) {
CheckOperationResultMsgs(
p68WithPSV60Result,
{"DXIL container mismatch for 'PSVRuntimeInfoSize' between 'PSV0' "
"part:('24') and DXIL module:('56')"},
"part:('24') and DXIL module:('52')"},
/*maySucceedAnyway*/ false, /*bRegex*/ false);
}
Loading