Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation for ID3D12FunctionReflection1::GetDesc1 #6827

Open
wants to merge 65 commits into
base: main
Choose a base branch
from

Commits on Jul 25, 2024

  1. Configuration menu
    Copy the full SHA
    b9608d6 View commit details
    Browse the repository at this point in the history
  2. Removed unused variable

    Nielsbishere committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    41ba55c View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Configuration menu
    Copy the full SHA
    365edc2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32db08b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5d26589 View commit details
    Browse the repository at this point in the history
  4. Implemented GetInputNode/GetOutputNode, changed formatting a bit, add…

    …ed some missing node information to the implementation.:
    Nielsbishere committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a42939f View commit details
    Browse the repository at this point in the history
  5. Added safety check to CFunctionReflection::GetDesc1 and renamed D3D12…

    …_NODE_OVERRIDES_TYPE to ..._LAUNCH_TYPE
    Nielsbishere committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    52aa9d9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7e39b81 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    0a78e0f View commit details
    Browse the repository at this point in the history
  2. DirectX-Headers is now required on Windows too, since otherwise it's …

    …not really possible to change things in DirectX-Headers without a Windows SDK update... Removed stupid hacks in dxexp.cpp, which were there because d3d12.h comes from the windows SDK. Now that DirectX-Headers is required, d3d12.h comes from the DirectX-Headers, meaning that the structs & enums that were hardcoded are now not needed anymore. It can now happily use the same headers without relying on specific windows SDKs :)
    Nielsbishere committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9814065 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    a0bb8b9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d23fcd2 View commit details
    Browse the repository at this point in the history
  3. WSL Stubs shouldn't be included by default anymore for linux, since d…

    …irectx headers have their own way of handling with it
    Nielsbishere committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    2b92066 View commit details
    Browse the repository at this point in the history
  4. Fixed formatting issue

    Nielsbishere committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    666dfae View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8be0aae View commit details
    Browse the repository at this point in the history
  6. Changed ID3D12ShaderReflection to ID3D12ShaderReflection1 and impleme…

    …nted it in QueryInterface
    Nielsbishere committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    895f80a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5676799 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6bc299e View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Fixed formatting

    Nielsbishere committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    8b97460 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2109491 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6fbe8a9 View commit details
    Browse the repository at this point in the history
  4. Exposed compute shader WaveSizeMin/Max/Preferred and mesh/amplificati…

    …on shaders numthreads to dxa.
    Nielsbishere committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ea62c4b View commit details
    Browse the repository at this point in the history
  5. Formatting

    Nielsbishere committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    530970c View commit details
    Browse the repository at this point in the history
  6. Made sure guids are taken from DirectX-Headers d3d12.h rather than el…

    …sewhere. And removed duplicate definition from ExecutionTest.cpp
    Nielsbishere committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3d777a0 View commit details
    Browse the repository at this point in the history
  7. Merge trunk into branch

    Nielsbishere committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4a4ce62 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2457465 View commit details
    Browse the repository at this point in the history
  9. Added predeclarations for LibraryReflection1 and ShaderReflection1. U…

    …nified typedefs between DXC and DirectX-Headers. Warning: This might need extra caution, as these sizes were mismatching before! unsigned long aka ULONG is 64-bit on linux but was treated as the same as on windows?
    Nielsbishere committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5a60043 View commit details
    Browse the repository at this point in the history
  10. Windows: wsl stubs aren't needed. Now requiring DirectX-Headers to en…

    …sure latest d3d12.h & d3d12shader.h. Fixed compile issue on gcc/clang due to missing {} in GetDesc1. Removed duplicate definitions in dxexp.cpp. Fixed formatting issue.
    Nielsbishere committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    9eca17a View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c88a1a6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a702d2c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    0a87922 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    506a167 View commit details
    Browse the repository at this point in the history
  2. Formatting. Also fixed unit test that relied on the ShaderKind of 'No…

    …de' not being translatable, even though now it is.
    Nielsbishere committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    988ada1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7c45598 View commit details
    Browse the repository at this point in the history
  4. Seems like ExecutionTest.cpp still has an issue with finding GUIDs th…

    …at are clearly defined by d3d12.h. If it's not the location of the INITGUID it must be picking the wrong d3d12.h
    Nielsbishere committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    32ac5ec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6defb75 View commit details
    Browse the repository at this point in the history
  6. Undid removal of definition of ID3D12SDKConfiguration UUIDs, which ar…

    …e apparently also needed even if d3d12 is defined. Defining GUID creation bugs everything out, so just doing it like this
    Nielsbishere committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fe507da View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    248ce58 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. dxc/WinAdapter.h now extends DirectX-Headers/WSL's winAdapter.h, to a…

    …void conflicts and allow the latest DirectX-Headers to be used rather than a 2 year outdated one. Unified lots of types; all fixed int types now align properly between windows and unix (more importantly; between the two winadapters). Removed duplicate defines and type definitions. Replaced CROSS_PLATFORM_UUIDOF with __CRT_UUID_DECL so that it can use the uuid macro from wsl. Fixed type incompatiblity of a LPBOOL which really refered to a bool* (BOOL is 32-bit according to WSL).
    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ac6c505 View commit details
    Browse the repository at this point in the history
  2. Restored most headers to what they used to be by adding the same defi…

    …nition that DirectX-Headers uses to define GUIDs so that either implementation of __uuidof can find the GUID.
    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    903325e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ae5c687 View commit details
    Browse the repository at this point in the history
  4. Fixed windows build

    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    dc19327 View commit details
    Browse the repository at this point in the history
  5. Clean up for PR

    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    631d446 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6e41faf View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    18a4894 View commit details
    Browse the repository at this point in the history
  8. Formatting

    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d1d195a View commit details
    Browse the repository at this point in the history
  9. Some compilers don't seem to like missing endline at the end of a fil…

    …e. Also don't like an include named winadapter.h in a file named WinAdapter.h
    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    d82e56d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9d72073 View commit details
    Browse the repository at this point in the history
  11. Clang still needs __wsl_stub_uuidof, even though it has builtin suppo…

    …rt. Added CLSID_D3D12SDKConfiguration for older Windows sdks
    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7883cda View commit details
    Browse the repository at this point in the history
  12. Formatting

    Nielsbishere committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    15d406c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    21a5225 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    e0272d7 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Configuration menu
    Copy the full SHA
    06a33f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0d91e56 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e000305 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0432255 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'main' of https://github.com/Microsoft/DirectXShaderComp…

    …iler into feat_query_all_function_properties3
    Nielsbishere committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    cca5f93 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    042ed57 View commit details
    Browse the repository at this point in the history
  7. Added unit tests by modifying existing unit tests to include reflecti…

    …on info (where it makes sense). Only unit tests that provide unique scenarios have been touched. Fixed some misformatting in D3DReflectionDumper. Apparently m_pProps can be NULL, so made it S_OK instead of E_FAIL. Fixed problem with GetInputNode/GetOutputNode where it returned a string pointer of a C++ struct which implictly copied due to not being const&.
    Nielsbishere committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4faa40c View commit details
    Browse the repository at this point in the history
  8. Apparently even though DXA runs fine, the file checker uses something…

    … else. Changed it to use ShaderReflection1 and LibraryReflection1
    Nielsbishere committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    74e793d View commit details
    Browse the repository at this point in the history
  9. Fixed a few tests; replaced LibraryReflection with LibraryReflection1…

    … in checks, same for ShaderReflection1. Also fixed the RDAT3 in wavesize-compute-node-rdat.hlsl
    Nielsbishere committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    98774b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    4d33ef8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    828e48e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4c81c8c View commit details
    Browse the repository at this point in the history
  4. Apparently the featureflag with SM6.8 isn't set for SM6.7 when sm65_m…

    …s_as.hlsl is compiled as lib_6_8
    Nielsbishere committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7ed6944 View commit details
    Browse the repository at this point in the history