HLSLTestLib: Support xfailcat: acts like xfail but propagates stdin,stdout #6711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an exception is thrown, don't block it in the TempOverloadPool destructor. Allow it to propagate out as a user-visible error. Explicitly clear the TempOverloadPool before returning from the HLMatrixLowerPass::runOnModule. In the normal case, when no exception is thrown, that will still verify that all the overloads actually have been lowered, and will assert out if they aren't.
…tdout Add support for 'xfailcat' in RUN: commands. It requires the prior command to fail, and also propagates stdout and stderr. This is useful for cases for parsing error messages, example // RUN: %dxc -T cs_6_0 will_fail.hlsl %s | xfailcat | FileCheck %s // CHECK: error: something blah blah This is an alternativ to supporting 'not'. Also, modify the test from microsoft#6710 to check the error message
|
But we do support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for 'xfailcat' in RUN: commands.
It requires the prior command to fail, and also propagates
stdout and stderr.
This is useful for cases for parsing error messages, example
This is an alternative to supporting 'not'.
Builds on #6710.
Also, modify the test from #6710 to check the error message