Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend template specialization DXASSERT conditions #6617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Aug 15, 2024

  1. Amend template specialization DXASSERT conditions

    Clang suppresses template specialization if a fatal error has been
    reported in order to reduce the risk of a cascade of secondary error
    diagnostics.
    
    However, DXC DXASSERTs if template specialization fails - even if that
    is due to an unrelated fatal error - which has the unintended result of
    hiding the fatal error and hence providing no indication of what the
    problem is.
    
    The DXASSERT conditions have been amended so they are no longer raised
    if a fatal error has been registered.
    Tim Corringham committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    76a8f5f View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Update template specialization assert handling

    Amend the fix for DXASSERTS in template specialization by incorporating
    changes from review comments.
    Tim Corringham committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    775da60 View commit details
    Browse the repository at this point in the history