fix: remove unused WorkflowEvent import and restore 'invalid content' retry check#275
Merged
Merged
Conversation
… retry check - Remove unused WorkflowEvent import from migration_processor.py (fixes lint F401) - Restore 'model produced invalid content' transient error retry in azure_openai_response_retry.py (regression from agent-framework 1.3.0 refactor) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dhanushree-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Roopan-Microsoft,
aniaroramsft,
dgp10801,
nchandhi,
sethsteenken and
toherman-msft
as code owners
Dhanushree-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Dhanushree-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Dhanushree-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Coverage Report •
|
Processor Coverage Report •
|
||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses follow-up items from prior review by removing an unused WorkflowEvent import that caused lint failures and by restoring a dropped transient-retry condition for Azure OpenAI “invalid content” errors during the agent-framework 1.3.0 refactor.
Changes:
- Removed unused
WorkflowEventimport frommigration_processor.pyto resolve F401. - Re-added detection of “model produced invalid content” / “invalid content” as a retryable transient error in Azure OpenAI response retry logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/processor/src/steps/migration_processor.py |
Removes an unused import to fix linting. |
src/processor/src/libs/agent_framework/azure_openai_response_retry.py |
Restores retry classification for Azure OpenAI “invalid content” transient failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dhanushree-Microsoft
temporarily deployed
to
production
GitHub Actions
Inactive
Avijit-Microsoft
approved these changes
Jun 5, 2026
Roopan-Microsoft
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addresses review comments from PR #273:
Remove unused \WorkflowEvent\ import from \migration_processor.py\ — it was imported but never used in code (only referenced in a comment), causing lint failure (F401).
Restore 'model produced invalid content' transient error retry in \�zure_openai_response_retry.py\ — this check existed on \main\ but was accidentally dropped during the agent-framework 1.3.0 refactor in PR fix: Refactor code structure for improved readability and maintainability #272. Without it, structured response validation failures from Azure OpenAI won't be retried.
Does this introduce a breaking change?