Guoye/merge embr final #3560
Open
Guoye/merge embr final #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistent with GPUMatrix.h
vmazalov
reviewed
Jan 27, 2019
| @@ -23,7 +23,7 @@ | |||
| #include <algorithm> // for find() | |||
| #include "simplesenonehmm.h" | |||
| #include "Matrix.h" | |||
|
|
|||
| #include <set> | |||
There was a problem hiding this comment.
Do we need them sorted? Otherwise we can use unordered_set
vmazalov
reviewed
Jan 27, 2019
| { | ||
| // for sorting purpose | ||
| // make sure the map is stored with keys in descending order | ||
| std::map<double, std::vector<PrevTokenInfo>, std::greater <double>> mp_score_token_infos; // for sorting the tokens in map |
There was a problem hiding this comment.
why not ordered_map? -- similarly in other places.
There was a problem hiding this comment.
the map is for ordering purpose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the EMBR code for sequence training: EMBR is WER based sequence training method, it has been used for all MS ASR production model with very good gains.