resolve options and deprecation warnings #327
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
apisarenco
changed the title
|
Any update on this PR? |
|
Hi @apisarenco and @jaja-git, thanks for your interest in contributing to the CDM project. We are evaluating the changes internally. Once a final decision has been made, we will get back with the next steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 issues:
ResolveOptionsis used in code, but it was only imported whenTYPE_CHECKING. This caused calls toattribute.fetch_object_definition()to fail.doc.namespaceanddoc.folder_pathusage todoc.owner.namespaceanddoc.owner.folder_path, as the deprecation warnings suggested.