Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluent: add dedicated loader animation #5423

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Fluent: add dedicated loader animation #5423

merged 5 commits into from
Feb 11, 2025

Conversation

OEvgeny
Copy link
Collaborator

@OEvgeny OEvgeny commented Feb 10, 2025

Changelog Entry

Added

  • Added dedicated loading animation for messages in preparing state for Fluent theme, in PR #5423, by @OEvgeny

Description

This PR introduces a dedicated loading animation for messages in the preparing state in the Fluent theme.

Design

  • Uses SVG-based animation with gradient colors that match Fluent theme
  • Implements loader through decorator middleware and dedicated composer

Specific Changes

  • Added new ActivityLoader component with custom SVG animation
  • Created CSS modules for loader styling and positioning
  • Extended ActivityDecorator styles to handle loader presentation
  • Added decorator middleware to render loader during "preparing" livestream state
  • Integrated loader with DecoratorComposer in FluentThemeProvider
  • I have added tests and executed them locally
  • I have updated CHANGELOG.md
  • I have updated documentation

Review Checklist

  • Accessibility reviewed (tab order, content readability, alt text, color contrast)
  • Browser and platform compatibilities reviewed
  • CSS styles reviewed (minimal rules, no z-index)
  • Documents reviewed (docs, samples, live demo)
  • Internationalization reviewed (strings, unit formatting)
  • package.json and package-lock.json reviewed
  • Security reviewed (no data URIs, check for nonce leak)
  • Tests reviewed (coverage, legitimacy)

@OEvgeny OEvgeny marked this pull request as ready for review February 11, 2025 00:06
CHANGELOG.md Show resolved Hide resolved
compulim
compulim previously approved these changes Feb 11, 2025
Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking.

@OEvgeny OEvgeny enabled auto-merge (squash) February 11, 2025 22:47
@OEvgeny OEvgeny merged commit 4091100 into main Feb 11, 2025
27 checks passed
@OEvgeny OEvgeny deleted the feat/fluent-loader branch February 11, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants