[Shopify] Remove duplicate OnAfterCreatedNewCompanyByCopyCompany subscriber#8576
Open
onbuyuka wants to merge 1 commit into
Open
[Shopify] Remove duplicate OnAfterCreatedNewCompanyByCopyCompany subscriber#8576onbuyuka wants to merge 1 commit into
onbuyuka wants to merge 1 commit into
Conversation
…criber ShpfyInstaller.Codeunit.al had two byte-for-byte identical event subscribers on Report::`Copy Company`.OnAfterCreatedNewCompanyByCopyCompany - ShpfyOnAfterCreatedNewCompanyByCopyCompany and HandleOnAfterCreatedNewCompanyByCopyCompany. Both ran Shop.ChangeCompany + Shop.ModifyAll(Enabled, false) on the new company; the second one was a redundant no-op. Likely a copy-paste leftover from the Shopify -> BCApps migration (PR #4241). Keeping the Shpfy* named procedure to match the sibling ShpfyOnClearCompanyConfiguration naming convention. Fixes AB#638257 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShpfyInstaller.Codeunit.alhad two byte-for-byte identical event subscribers onReport::"Copy Company".OnAfterCreatedNewCompanyByCopyCompany:ShpfyOnAfterCreatedNewCompanyByCopyCompany(kept)HandleOnAfterCreatedNewCompanyByCopyCompany(removed)Both ran
Shop.ChangeCompany(NewCompanyName); Shop.ModifyAll(Enabled, false);on the newly copied company. The second handler was a redundant no-op (the first already setEnabled = false).git blameshows both procedures landed together in #4241 (the Shopify -> BCApps migration) - clearly a copy-paste leftover. Zero functional impact, just cleanup. Kept theShpfy*named procedure to match the naming convention used by its siblingShpfyOnClearCompanyConfigurationdirectly below.Work Item(s)
Fixes AB#638257