Skip to content

[E-Documents Core] [Peppol] - Enabling EDI capabilities with E-Documents. Receive path (Sales Order ← E‑Document)#8558

Open
jzaksauskas wants to merge 38 commits into
microsoft:mainfrom
jzaksauskas:dev/aan/salesorder-inbound-edocument
Open

[E-Documents Core] [Peppol] - Enabling EDI capabilities with E-Documents. Receive path (Sales Order ← E‑Document)#8558
jzaksauskas wants to merge 38 commits into
microsoft:mainfrom
jzaksauskas:dev/aan/salesorder-inbound-edocument

Conversation

@jzaksauskas

Copy link
Copy Markdown
Contributor

Implementation

Enables electronic document import for sales orders in PEPPOL BIS 3.0 format, allowing suppliers to send structured order documents to customers.

Key additions:

  • Adds PEPPOL Order XML support to the structured import flow.
  • Introduces sales-order-specific draft tables, pages, and processing components.
  • Creates Sales Orders from prepared E-Document drafts and links them to the source E-Document.
  • Improves customer and sales line resolution using buyer identifiers, item identifiers, and item references.
  • Adds extensibility interfaces for customer lookup, sales line resolution, and sales order creation.
  • Extends permissions and inbound document UI to support sales order drafts.
  • Adds telemetry and activity logging for matching, draft handling, and document creation.
  • Adds safeguards and reset behavior for Sales Orders linked to E-Documents.
  • Expands automated test coverage for parsing, draft preparation, creation, undo flow, and duplicate detection.

Linked work

Fixes #

AndriusAndrulevicius and others added 30 commits May 5, 2026 14:08
Introduces two new internal tables to store structured sales order data extracted from incoming e-documents.

Separates external document data (buyer/seller details, amounts, line items) from validated Business Central mappings (customer, item, UOM, dimensions), making the import draft workflow clearer and more maintainable.

Includes telemetry logging on draft deletion to support feature usage tracking.
Introduces three interfaces to allow customization of how E-Documents are processed into sales orders: customer resolution, sales line item assignment, and sales order creation.

This enables downstream extensions to override default import behavior without modifying core logic.
Introduces a new draft processing implementation for inbound sales orders, allowing the E-Document framework to handle sales-side structured data imports alongside the existing purchase document flows.

Table IDs for sales staging data are temporarily reassigned to avoid conflicts during development.
Ensures the Sales import namespace is available in the E-Document processing draft enum, resolving potential dependency or compilation issues.
Introduces a new provider codeunit to resolve customers and items for inbound sales e-documents.

Customer matching tries GLN, Service Participant, VAT ID, and company name in order. Item matching tries seller item ID, GTIN, bar code item reference, and customer item reference. Each successful match logs activity and telemetry for traceability.

Adds supporting activity log tokens for the new item identification strategies.
Extends the e-document import pipeline to support sales scenarios alongside the existing purchase flow.

Introduces customer resolution, sales line mapping, and sales order creation as extensible interface implementations, enabling incoming e-documents to be drafted as sales orders.
Extends the `IProcessStructuredData` interface with a `GetCustomer` method, enabling customer resolution alongside the existing vendor resolution pattern.

Sales draft preparation now properly resolves and persists the customer during draft creation, and cleanup logic is implemented to remove associated staging records when needed.

Purchase and credit memo draft implementations provide stub implementations to satisfy the updated interface contract.
Introduces infrastructure to create BC sales documents from imported e-document draft lines, mirroring the existing purchase document flow.

Adds an E-Document Link field to Sales Header for tracking which e-document produced a given sales document, enabling proper cleanup and revert behavior when the sales document is deleted.

Includes link record support between e-document sales lines and BC sales lines, and a delete guard that reverts the e-document status back to draft when its linked sales document is removed.
Adds full logic for creating BC Sales Orders and Blanket Orders from inbound Peppol Order e-document drafts, including header and line mapping from staged draft data.

Introduces duplicate order detection based on external document number and customer, and routes document type based on order type code. Telemetry is logged for validation failures to aid diagnostics.
Extends the e-document import pipeline to handle incoming PEPPOL BIS 3.0 Order XML, enabling sales orders to be received and processed alongside existing invoice and credit note flows.

Introduces a draft page and subform for reviewing and finalizing imported sales orders, including buyer/seller party details, order lines, totals, and dimension support.

Implements XML parsing for sales order headers and lines, with fallback total computation from lines when AnticipatedMonetaryTotal is absent.
Wires up the Sales Order e-document type with a concrete draft finalization handler, enabling the full processing pipeline for imported sales orders.
Extends permission sets to include sales header and line tables, pages, and codeunits needed for processing inbound sales documents.

Updates the Inbound E-Documents page to display the correct sender name based on document type, showing buyer info for sales orders and vendor info for purchase documents.

Adds sales order line retrieval in document processing to support the full inbound sales document workflow.
Fixes object IDs and namespaces for sales order import codeunits, pages, and tables to use proper ranges instead of temporary IDs.

Adds support for document-level allowance/charge lines in PEPPOL orders, ensuring charges are captured as separate sales lines.

Improves customer resolution by adding fuzzy name/address matching and support for buyer external identifiers via service participants.

Expands blanket order support by including blanket order lines when querying source document lines, and adds validation for unsupported order type codes.

Extends the sales line table relation to support additional BC sales line types such as G/L accounts, fixed assets, and allocation accounts.
…oDraft

Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/1800a6ba-f635-4c5b-8523-1304d870b6e4

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Removes OrderTypeCode-based document type routing so all inbound PEPPOL orders always produce a Sales Order, eliminating the unsupported type code error path.

Fixes the duplicate order telemetry log to include the actual order and customer values, and renames the document existence check to better reflect its intent.

Adds `IsBlanketOrder()` helper on the staging header and a `BlanketOrderTypeCodeTok` constant for future use by extensions.

Removes line-level discount accumulation from the PEPPOL totals calculation to avoid double-counting.

Adds a mock `IEDocumentCreateSalesOrder` implementation and a comprehensive suite of PEPPOL Order parsing and FinishDraft tests, covering standard orders, unsupported type codes, missing monetary totals, originator party, TaxTotal VAT fallback, multiple delivery blocks, document-level charges, and description fallback logic.
… test file conflict

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/ed1085eb-3b72-4401-8afa-4081a1a31b68

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/d1b8e500-3c77-43b4-8248-d6674d50f966

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… customer guard

Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/3c433d9d-78cb-4888-ba64-5a1cd3efd253

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…l references

Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/5e772852-7fbf-4b09-99ab-a839221f3ed4

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…icate check

Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/811950b8-eeaf-4c22-ad8f-d0b68af0f338

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
…level charge omission

Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/a0efd20b-38b4-416f-9c16-65288ee2d0b1

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Reassigns the codeunit object ID to avoid potential conflicts with existing IDs in the range.
…bound-edocument

# Conflicts:
#	src/Apps/W1/EDocument/Test/src/Processing/EDocProcessTest.Codeunit.al

Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
AndriusAndrulevicius and others added 8 commits June 8, 2026 11:03
Moves `GetCustomer` out of the general structured data interface into a new sales-specific interface that extends it. This better reflects the separation of concerns between purchase and sales document processing, since purchase-side codeunits have no need to resolve a customer.

Removes unused `Customer` using directives and empty `GetCustomer` stub implementations from purchase-related codeunits, reducing noise and avoiding misleading method signatures.

Renames sales draft page files to more consistent naming and adds a missing tooltip to the VAT rate field in the sales draft subform.
Updates the codeunit ID from 6426 to 6429 to resolve a likely ID collision with another codeunit, ensuring unique identification within the system.
Extracts sender name population logic into a dedicated procedure to improve code organization and separation of concerns.

Marks the existing "Vendor Name" field as obsolete, replacing it with a properly named field to better reflect its purpose as a generic sender identifier rather than a vendor-specific concept.

Reduces description field length on sales lines to align with standard document line constraints, and adds missing usage category to the sales draft page.

Includes minor cleanup of using statement ordering across several files for consistency.
Bumps the clean version guard from CLEAN28 to CLEAN29 to extend the deprecation lifecycle of the vendor name field.

Also reorders namespace imports to follow alphabetical convention, improving consistency and readability.
@jzaksauskas jzaksauskas requested review from a team as code owners June 10, 2026 06:25
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork labels Jun 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link.

@jzaksauskas

Copy link
Copy Markdown
Contributor Author

@jzaksauskas please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

@microsoft-github-policy-service agree

@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Jun 10, 2026
@jzaksauskas

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@github-actions github-actions Bot removed the needs-approval Workflow runs require maintainer approval to start label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 From Fork Pull request is coming from a fork

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants