[E-Documents Core] [Peppol] - Enabling EDI capabilities with E-Documents. Receive path (Sales Order ← E‑Document)#8558
Conversation
Introduces two new internal tables to store structured sales order data extracted from incoming e-documents. Separates external document data (buyer/seller details, amounts, line items) from validated Business Central mappings (customer, item, UOM, dimensions), making the import draft workflow clearer and more maintainable. Includes telemetry logging on draft deletion to support feature usage tracking.
Introduces three interfaces to allow customization of how E-Documents are processed into sales orders: customer resolution, sales line item assignment, and sales order creation. This enables downstream extensions to override default import behavior without modifying core logic.
Introduces a new draft processing implementation for inbound sales orders, allowing the E-Document framework to handle sales-side structured data imports alongside the existing purchase document flows. Table IDs for sales staging data are temporarily reassigned to avoid conflicts during development.
Ensures the Sales import namespace is available in the E-Document processing draft enum, resolving potential dependency or compilation issues.
Introduces a new provider codeunit to resolve customers and items for inbound sales e-documents. Customer matching tries GLN, Service Participant, VAT ID, and company name in order. Item matching tries seller item ID, GTIN, bar code item reference, and customer item reference. Each successful match logs activity and telemetry for traceability. Adds supporting activity log tokens for the new item identification strategies.
Extends the e-document import pipeline to support sales scenarios alongside the existing purchase flow. Introduces customer resolution, sales line mapping, and sales order creation as extensible interface implementations, enabling incoming e-documents to be drafted as sales orders.
Extends the `IProcessStructuredData` interface with a `GetCustomer` method, enabling customer resolution alongside the existing vendor resolution pattern. Sales draft preparation now properly resolves and persists the customer during draft creation, and cleanup logic is implemented to remove associated staging records when needed. Purchase and credit memo draft implementations provide stub implementations to satisfy the updated interface contract.
Introduces infrastructure to create BC sales documents from imported e-document draft lines, mirroring the existing purchase document flow. Adds an E-Document Link field to Sales Header for tracking which e-document produced a given sales document, enabling proper cleanup and revert behavior when the sales document is deleted. Includes link record support between e-document sales lines and BC sales lines, and a delete guard that reverts the e-document status back to draft when its linked sales document is removed.
Adds full logic for creating BC Sales Orders and Blanket Orders from inbound Peppol Order e-document drafts, including header and line mapping from staged draft data. Introduces duplicate order detection based on external document number and customer, and routes document type based on order type code. Telemetry is logged for validation failures to aid diagnostics.
Extends the e-document import pipeline to handle incoming PEPPOL BIS 3.0 Order XML, enabling sales orders to be received and processed alongside existing invoice and credit note flows. Introduces a draft page and subform for reviewing and finalizing imported sales orders, including buyer/seller party details, order lines, totals, and dimension support. Implements XML parsing for sales order headers and lines, with fallback total computation from lines when AnticipatedMonetaryTotal is absent.
Wires up the Sales Order e-document type with a concrete draft finalization handler, enabling the full processing pipeline for imported sales orders.
Extends permission sets to include sales header and line tables, pages, and codeunits needed for processing inbound sales documents. Updates the Inbound E-Documents page to display the correct sender name based on document type, showing buyer info for sales orders and vendor info for purchase documents. Adds sales order line retrieval in document processing to support the full inbound sales document workflow.
Fixes object IDs and namespaces for sales order import codeunits, pages, and tables to use proper ranges instead of temporary IDs. Adds support for document-level allowance/charge lines in PEPPOL orders, ensuring charges are captured as separate sales lines. Improves customer resolution by adding fuzzy name/address matching and support for buyer external identifiers via service participants. Expands blanket order support by including blanket order lines when querying source document lines, and adds validation for unsupported order type codes. Extends the sales line table relation to support additional BC sales line types such as G/L accounts, fixed assets, and allocation accounts.
…oDraft Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/1800a6ba-f635-4c5b-8523-1304d870b6e4 Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Removes OrderTypeCode-based document type routing so all inbound PEPPOL orders always produce a Sales Order, eliminating the unsupported type code error path. Fixes the duplicate order telemetry log to include the actual order and customer values, and renames the document existence check to better reflect its intent. Adds `IsBlanketOrder()` helper on the staging header and a `BlanketOrderTypeCodeTok` constant for future use by extensions. Removes line-level discount accumulation from the PEPPOL totals calculation to avoid double-counting. Adds a mock `IEDocumentCreateSalesOrder` implementation and a comprehensive suite of PEPPOL Order parsing and FinishDraft tests, covering standard orders, unsupported type codes, missing monetary totals, originator party, TaxTotal VAT fallback, multiple delivery blocks, document-level charges, and description fallback logic.
… test file conflict Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/ed1085eb-3b72-4401-8afa-4081a1a31b68 Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/d1b8e500-3c77-43b4-8248-d6674d50f966 Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… customer guard Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/3c433d9d-78cb-4888-ba64-5a1cd3efd253 Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…l references Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/5e772852-7fbf-4b09-99ab-a839221f3ed4 Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…icate check Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/811950b8-eeaf-4c22-ad8f-d0b68af0f338 Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
…level charge omission Agent-Logs-Url: https://github.com/jzaksauskas/BCApps/sessions/a0efd20b-38b4-416f-9c16-65288ee2d0b1 Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Reassigns the codeunit object ID to avoid potential conflicts with existing IDs in the range.
…bound-edocument # Conflicts: # src/Apps/W1/EDocument/Test/src/Processing/EDocProcessTest.Codeunit.al Co-authored-by: AndriusAndrulevicius <30231314+AndriusAndrulevicius@users.noreply.github.com>
Moves `GetCustomer` out of the general structured data interface into a new sales-specific interface that extends it. This better reflects the separation of concerns between purchase and sales document processing, since purchase-side codeunits have no need to resolve a customer. Removes unused `Customer` using directives and empty `GetCustomer` stub implementations from purchase-related codeunits, reducing noise and avoiding misleading method signatures. Renames sales draft page files to more consistent naming and adds a missing tooltip to the VAT rate field in the sales draft subform.
Updates the codeunit ID from 6426 to 6429 to resolve a likely ID collision with another codeunit, ensuring unique identification within the system.
Extracts sender name population logic into a dedicated procedure to improve code organization and separation of concerns. Marks the existing "Vendor Name" field as obsolete, replacing it with a properly named field to better reflect its purpose as a generic sender identifier rather than a vendor-specific concept. Reduces description field length on sales lines to align with standard document line constraints, and adds missing usage category to the sales draft page. Includes minor cleanup of using statement ordering across several files for consistency.
Bumps the clean version guard from CLEAN28 to CLEAN29 to extend the deprecation lifecycle of the vendor name field. Also reorders namespace imports to follow alphabetical convention, improving consistency and readability.
|
Could not find linked issues in the pull request description. Please make sure the pull request description contains a line that contains 'Fixes #' followed by the issue number being fixed. Use that pattern for every issue you want to link. |
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree |
Implementation
Enables electronic document import for sales orders in PEPPOL BIS 3.0 format, allowing suppliers to send structured order documents to customers.
Key additions:
Linked work
Fixes #