Skip to content

Add /otlp/ segment to observability exporter URL paths#235

Merged
nikhilNava merged 5 commits intomainfrom
copilot/implement-pr-in-dotnet
Apr 14, 2026
Merged

Add /otlp/ segment to observability exporter URL paths#235
nikhilNava merged 5 commits intomainfrom
copilot/implement-pr-in-dotnet

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 10, 2026

  • Update Agent365ExporterCore.BuildEndpointPath to include /otlp/ segment in both standard and S2S URL paths
  • Update Agent365ExporterOptions XML doc comments to reflect new URL format
  • Update test assertions in Agent365ExporterTests.cs to match new URL paths
  • Add Export_RequestUri_S2SEndpoint_ContainsOtlpSegment test to validate S2S route includes /otlp/ segment
  • Build and test to verify changes

@nikhilNava nikhilNava marked this pull request as ready for review April 10, 2026 14:07
@nikhilNava nikhilNava requested a review from a team as a code owner April 10, 2026 14:07
Copilot AI review requested due to automatic review settings April 10, 2026 14:07
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 4cb5359.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Agent365 OTLP trace exporter URL construction to include an /otlp/ segment in the route, aligning the .NET runtime exporter endpoint paths with the OTLP naming convention used by other SDKs.

Changes:

  • Inserted /otlp/ into the standard and S2S exporter endpoint paths generated by Agent365ExporterCore.BuildEndpointPath.
  • Updated Agent365ExporterOptions XML docs to reflect the new route shapes.
  • Updated exporter URL assertions in Agent365ExporterTests to include the /otlp/ segment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Observability/Runtime/Tracing/Exporters/Agent365ExporterCore.cs Adjusts endpoint path generation to include /otlp/ for both standard and S2S routes.
src/Observability/Runtime/Tracing/Exporters/Agent365ExporterOptions.cs Updates documentation strings to match the new endpoint paths.
src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Exporters/Agent365ExporterTests.cs Updates request URI assertions to expect /otlp/ in the standard route.

Copilot AI requested review from Copilot and removed request for Copilot April 14, 2026 19:55
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 14, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • agent365.svc.cloud.microsoft
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/Agent365-dotnet/Agent365-dotnet/src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/bin/Debug/net8.0/Microsoft.Agents.A365.Observability.Runtime.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/Agent365-dotnet/Agent365-dotnet/src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/bin/Debug/net8.0/Microsoft.Agents.A365.Observability.Runtime.Tests.deps.json /home/REDACTED/work/Agent365-dotnet/Agent365-dotnet/src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/bin/Debug/net8.0/testhost.dll --port 44795 --endpoint 127.0.0.1:044795 --role client --parentprocessid 4128 --telemetryoptedin false (dns block)
  • override.example.com
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/Agent365-dotnet/Agent365-dotnet/src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/bin/Debug/net8.0/Microsoft.Agents.A365.Observability.Runtime.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/Agent365-dotnet/Agent365-dotnet/src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/bin/Debug/net8.0/Microsoft.Agents.A365.Observability.Runtime.Tests.deps.json /home/REDACTED/work/Agent365-dotnet/Agent365-dotnet/src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/bin/Debug/net8.0/testhost.dll --port 44795 --endpoint 127.0.0.1:044795 --role client --parentprocessid 4128 --telemetryoptedin false (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from gwharris7 April 14, 2026 19:56
Copilot AI review requested due to automatic review settings April 14, 2026 20:01
@nikhilNava nikhilNava requested a review from a team as a code owner April 14, 2026 20:01
@nikhilNava nikhilNava enabled auto-merge (squash) April 14, 2026 20:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

@nikhilNava nikhilNava merged commit 7ffb9e4 into main Apr 14, 2026
8 of 9 checks passed
@nikhilNava nikhilNava deleted the copilot/implement-pr-in-dotnet branch April 14, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants