Add /otlp/ segment to observability exporter URL paths#235
Merged
nikhilNava merged 5 commits intomainfrom Apr 14, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/Agent365-dotnet/sessions/b70504fd-76dc-41f8-977e-bfa0f1c97832 Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
nikhilNava
April 10, 2026 14:06
View session
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Agent365 OTLP trace exporter URL construction to include an /otlp/ segment in the route, aligning the .NET runtime exporter endpoint paths with the OTLP naming convention used by other SDKs.
Changes:
- Inserted
/otlp/into the standard and S2S exporter endpoint paths generated byAgent365ExporterCore.BuildEndpointPath. - Updated
Agent365ExporterOptionsXML docs to reflect the new route shapes. - Updated exporter URL assertions in
Agent365ExporterTeststo include the/otlp/segment.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Observability/Runtime/Tracing/Exporters/Agent365ExporterCore.cs | Adjusts endpoint path generation to include /otlp/ for both standard and S2S routes. |
| src/Observability/Runtime/Tracing/Exporters/Agent365ExporterOptions.cs | Updates documentation strings to match the new endpoint paths. |
| src/Tests/Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Exporters/Agent365ExporterTests.cs | Updates request URI assertions to expect /otlp/ in the standard route. |
Agent-Logs-Url: https://github.com/microsoft/Agent365-dotnet/sessions/66b4a8d9-6b2a-4286-83d6-6303586e8117 Co-authored-by: gwharris7 <96964444+gwharris7@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…icrosoft/Agent365-dotnet into copilot/implement-pr-in-dotnet
...Microsoft.Agents.A365.Observability.Runtime.Tests/Tracing/Exporters/Agent365ExporterTests.cs
Show resolved
Hide resolved
gwharris7
approved these changes
Apr 14, 2026
fpfp100
approved these changes
Apr 14, 2026
fpfp100
reviewed
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent365ExporterCore.BuildEndpointPathto include/otlp/segment in both standard and S2S URL pathsAgent365ExporterOptionsXML doc comments to reflect new URL formatAgent365ExporterTests.csto match new URL pathsExport_RequestUri_S2SEndpoint_ContainsOtlpSegmenttest to validate S2S route includes/otlp/segment