Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

umqtt.simple: add ping_response_received for ping handling #850

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trescenzi
Copy link

Currently when using ping the response is swallowed which makes it not particularly useful. This PR adds a flag ping_response_received to the client which is set to True if a response has been received in wait_msg. I've been using this approach in a personal project without any issues and it's not particularly invasive so I wanted to propose it as a solution to #332.

Another possible approach is to actually respond in wait_msg with an actual ping response however I'm not certain how that would interact with subscriptions and those currently using wait_msg so this approach was taken in order to not be breaking while still being useful.

@trescenzi trescenzi force-pushed the umqtt-simple-ping-response-flag branch from 8bd8a40 to 8322f75 Compare April 23, 2024 23:15
@trescenzi trescenzi force-pushed the umqtt-simple-ping-response-flag branch from 8322f75 to e6bc446 Compare April 23, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant