USM-20-update-docker #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotroisi
approved these changes
Dec 8, 2016
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 77.27% 77.27%
=======================================
Files 4 4
Lines 66 66
=======================================
Hits 51 51
Misses 13 13
Partials 2 2Continue to review full report at Codecov.
|
marcotroisi
reviewed
Jan 27, 2017
| @@ -2,4 +2,4 @@ FROM docker.io/microlib/golang-base:1.7 | |||
|
|
|||
| # This will change depending on each microservice entry point | |||
| # This will change to the binary start in production based images | |||
| CMD ["/bin/sh", "go run main.go"] | |||
| CMD ["/usr/local/go/bin/go", "run", "main.go"] | |||
There was a problem hiding this comment.
@luigizuccarelli I was wondering if we shouldn't add an ENTRYPOINT that simply runs the go executable. And then the CMD on top of that. In that way we might not need to change the Dockerfile for production, we just run it with a different command.
What do you think?
There was a problem hiding this comment.
Yes entrypoint is the correct way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Updated Dockerfile to allow for simple entry point start for local dev and updated the README
Motivation:
Allow the local developer to build and execute docker container locally
Resolution:
Added simple instructions in the README
Ticket:
USM-20