Fixed the payment pop-up window issue #2534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mar-v-in
reviewed
Sep 24, 2024
| @@ -232,7 +232,8 @@ class InAppBillingServiceImpl(private val context: Context) : IInAppBillingServi | |||
| developerPayload: String? | |||
| ): Bundle { | |||
| if (Log.isLoggable(TAG, Log.DEBUG)) Log.d(TAG, "getBuyIntent(apiVersion=$apiVersion, packageName=$packageName, sku=$sku, type=$type, developerPayload=$developerPayload)") | |||
| return resultBundle(BillingResponseCode.BILLING_UNAVAILABLE, "Not yet implemented") | |||
| return runCatching { getBuyIntentExtraParams(apiVersion, packageName!!, sku!!, type!!, developerPayload, null) } | |||
There was a problem hiding this comment.
Why is it necessary to catch exceptions here? Shouldn't they be catched in getBuyIntentExtraParams if that was necessary?
There was a problem hiding this comment.
It is not certain whether the passed parameter is empty. Temporarily catch the exception here to avoid abnormal crash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue that the payment pop-up page could not be displayed after clicking on the payment.
e.g. uk.co.nationalrail.google