Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using FIDO2 authenticators with a PIN #2194

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Allow using FIDO2 authenticators with a PIN #2194

merged 9 commits into from
Aug 19, 2024

Commits on Jul 31, 2024

  1. Added rudimentary support for PIN verification for FIDO2

    @TheMartinizer
    TheMartinizer committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b3d53f4 View commit details
    Browse the repository at this point in the history

  2. Added handling of Wrong PIN. Fixed a bug where pinHashEnc could be to… 

    …o long
    @TheMartinizer
    TheMartinizer committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b166070 View commit details
    Browse the repository at this point in the history

  3. Don't ask for PIN codes when unecessary. Handle PIN required exceptio… 

    …n from authenticator
    @TheMartinizer
    TheMartinizer committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c958de2 View commit details
    Browse the repository at this point in the history

  4. If no signOptions are provided, we should default to asking for PIN, … 

    …since this is the safest option. Firefox doesn't seem to pass on either SignOptions or RegisterOptions properly
    @TheMartinizer
    TheMartinizer committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e4f5ae1 View commit details
    Browse the repository at this point in the history

  5. Took some clarification regarding the uv flag from drafts of CTAP2.1 … 

    …into account
    @TheMartinizer
    TheMartinizer committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    23a2f03 View commit details
    Browse the repository at this point in the history

  6. Use only CTAP2 for registration when strictly necessary. Use named va… 

    …riables for PIN subcommands
    @TheMartinizer
    TheMartinizer committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f20c68b View commit details
    Browse the repository at this point in the history

  7. Use the methods in the CtapConnection class to find out its capabilit… 

    …ies, instead of explicitly calculating them
    @TheMartinizer
    TheMartinizer committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    cbfb4ad View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Fido: Make PIN input compatible backwards to Android 6.0

    @mar-v-in
    mar-v-in committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3650924 View commit details
    Browse the repository at this point in the history

  2. Fido: Improve PIN entry UX

    @mar-v-in
    mar-v-in committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b185f3a View commit details
    Browse the repository at this point in the history