Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid resetting serial terminal when possible #1117

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

microbit-matt-hillsdon
Copy link
Collaborator

Follow up to ca1f325

This aims to avoid EVENT_RESET when its due to the workaround we have in place that disconnects background tabs.

@github-actions
Copy link

)}
<Box
// Need to render this when not connected as we need it to maintain scrollback across disconnect/reconnect in some cases.
display={connected ? undefined : "none"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until this change, reset wasn't really what was resetting the terminal—we were also discarding it entirely.

Need to review for unexpected consequences here.

Follow up to ca1f325

This aims to avoid EVENT_RESET when its due to the workaround we have in
place that disconnects background tabs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant