Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: add details to InstrumentModelEnum #2133

Open
mslarae13 opened this issue Jul 18, 2024 · 1 comment
Open

Draft: add details to InstrumentModelEnum #2133

mslarae13 opened this issue Jul 18, 2024 · 1 comment

Comments

@mslarae13
Copy link
Contributor

mslarae13 commented Jul 18, 2024

See #2132

If we're going to use instrument_model as the search function for the data portal, we need to expand on the enum

Add title so it's not snake case and a description

@kheal @SamuelPurvine @corilo @turbomam

@kheal
Copy link

kheal commented Sep 27, 2024

Another detail we could add is to include mappings the MS ontology for the mass spectrometry instruments - https://ontobee.org/ontology/MS?iri=http://purl.obolibrary.org/obo/MS_1000031. The sequencing instruments have already been mapped to OBI ontology, but there aren't appropriate mappings in that ontology to the mass spectrometry instruments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants