Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slot: host_disease_stat #1336

Closed
Tracked by #1335
bmeluch opened this issue Nov 11, 2023 · 6 comments · Fixed by #1408
Closed
Tracked by #1335

Add slot: host_disease_stat #1336

bmeluch opened this issue Nov 11, 2023 · 6 comments · Fixed by #1408
Assignees

Comments

@bmeluch
Copy link
Contributor

bmeluch commented Nov 11, 2023

"host_disease_stat" is listed in the MIxS "Plant-Associated" extension but I could not find it in the NMDC schema documentation or mixs.yaml, is there a reason it did not get imported?

host_disease_stat
List of diseases with which the host has been diagnosed; can include multiple diagnoses. The value of the field depends on host; for humans the terms should be chosen from the DO (Human Disease Ontology) at https://www.disease-ontology.org/, non-human host diseases are free text
Expected_value: disease name or Disease Ontology term

This is an EMSL metadata field, adding to the schema to support EMSL users in the submission portal.

@bmeluch bmeluch transferred this issue from microbiomedata/issues Nov 11, 2023
@bmeluch bmeluch changed the title host_disease_stat Add slot: host_disease_stat Nov 11, 2023
@bmeluch
Copy link
Contributor Author

bmeluch commented Nov 14, 2023

@turbomam @mslarae13 any guidance or thoughts on this slot/importing this slot from MIxS?

@bmeluch bmeluch self-assigned this Nov 14, 2023
@turbomam
Copy link
Member

There is a long complicated story about how MIxS terms have been imported into the nmdc-schema, and that's about to change with

For now, I have tied this issue to a branch, which will turn into a PR very shortly. It imports the definition of host_disease_stat into src/schema/mixs.yaml and makes host_disease_stat available to the Biosample class.

@turbomam
Copy link
Member

@bmeluch
Copy link
Contributor Author

bmeluch commented Nov 22, 2023

Thank you @turbomam for context + dealing with the complicated import issue!

@turbomam
Copy link
Member

reopening because this PR hasn't been merged yet:

So main doesn't build right now!

@turbomam turbomam reopened this Nov 27, 2023
@turbomam
Copy link
Member

turbomam commented Nov 27, 2023

https://github.com/GenomicsStandardsConsortium/mixs/blob/885b4544edd68ce42d9a55df217033bb3eee200d/src/mixs/schema/mixs.yaml#L8224-L8240

  host_disease_stat:
    annotations:
      Expected_value:
        tag: Expected_value
        value: disease name or Disease Ontology term
    description: List of diseases with which the host has been diagnosed; can include
      multiple diagnoses. The value of the field depends on host; for humans the terms
      should be chosen from the DO (Human Disease Ontology) at https://www.disease-ontology.org,
      non-human host diseases are free text
    title: host disease status
    in_subset:
      - nucleic acid sequence source
    keywords:
      - disease
      - host
      - host.
      - status
    string_serialization: '{termLabel} [{termID}]|{text}'
    slot_uri: MIXS:0000031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants