Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating kubernetes-client version #184

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

d-kononov
Copy link

No description provided.

@@ -38,6 +38,7 @@

import com.github.zafarkhaja.semver.Version;

import io.fabric8.kubernetes.api.model.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not replace classes with pounds...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@ljnelson
Copy link
Member

The main problem is the CRD handling. The 3.x client libraries need hacks that may not work with 4.x. Away from computer right now but will take a look after my day job.

@ljnelson
Copy link
Member

@d-kononov
Copy link
Author

BTW I use compiled jar file in my project and it works fine ;)

@sarvigalava
Copy link

Any update ? We need to upgrade the kubernetes client to 4.x version but the helm does not support it.

@ljnelson
Copy link
Member

Not ignoring you folks; just need to get to this on my open source development schedule (read: nights and weekends!).

@ljnelson
Copy link
Member

Working on this now. Probably won't pull in this PR exactly but I will incorporate its contents and credit you—and I thank you greatly for your work.

@ljnelson ljnelson self-assigned this Feb 14, 2019
@ljnelson ljnelson added the in progress In progress label Feb 14, 2019
@ljnelson ljnelson added this to the Next Release milestone Feb 14, 2019
ljnelson added a commit that referenced this pull request Feb 14, 2019
@ljnelson
Copy link
Member

@d-kononov @fidget83 I have deployed microbean-helm version 2.12.3.0.0.1-SNAPSHOT to the Sonatype snapshots repository. It incorporates the spirit of this pull request. I would appreciate any testing you might be able to perform.

@tareksha
Copy link

hi @ljnelson , @fidget83 , @d-kononov ,
I'm little conservative about ad-hoc managing the grpc dependencies in my project that uses microbean-helm and prefer using an out-of-the-box solution. Is a release planned soon here?
BTW kubernetes-client have already released 4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress In progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants