Skip to content

Conversation

@niten94
Copy link

@niten94 niten94 commented Jan 7, 2025

There are platforms where SYS_IOCTL is not defined probably because libc functions have to be used. Reasons why Syscall cannot be used in any platform may be added or changed but they would be handled in x/sys/unix and Go source code, so the call is replaced in this pull request.

Small unrelated style changes were also done in other commits.

Edit: The code in the orgnanization repository only is changed, so the issues in the old fork are not closed with this pull request now.

Copy link
Member

@JoeKar JoeKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, in case it works.
Should we go to v0.31.0 now?

@niten94
Copy link
Author

niten94 commented Mar 24, 2025

I tested the pull request on OpenIndiana (illumos distribution) last week but I was able to cross-compile and run Micro.

Should we go to v0.31.0 now?

I could update it, but I do not know if dependency packages like x/sys where there aren't much changes would usually be updated in Go software. The minimum Go version is newer than that of Micro, so I think it is probably better to not update it.

@JoeKar
Copy link
Member

JoeKar commented Mar 24, 2025

The minimum Go version is newer than that of Micro, so I think it is probably better to not update it.

Good point.
Then we keep it as proposed. 👍

Copy link
Member

@JoeKar JoeKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmaluka:
Any complains?
When we pick this one up within micro, then it's the first step towards *BSD support again.
We then just need micro-editor/tcell#2 too.

@dmaluka
Copy link

dmaluka commented Mar 24, 2025

LGTM.

@dmaluka dmaluka merged commit e587e95 into micro-editor:master Mar 24, 2025
@dmaluka
Copy link

dmaluka commented Mar 24, 2025

4be3967 has reminded me that we ought to do the same in micro... Uploaded zyedidia/micro#3704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants