Make heading subtitle optional

michalsnik · Jul 17, 2018 · 2c9d28a · 2c9d28a
1 parent e983872
commit 2c9d28a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -47,6 +47,7 @@ ember install ember-content-placeholders
 
 * yield `placeholder.heading`
   * Boolean `img` (default: false)
+  * Boolean `subtitle` (default: true)
 
 
 * yield `placeholder.text`

diff --git a/addon/components/content-placeholders-heading.js b/addon/components/content-placeholders-heading.js
@@ -4,5 +4,6 @@ import layout from '../templates/components/content-placeholders-heading';
 export default ContentPlaceholersBase.extend({
   className: 'ember-content-placeholders-heading',
   classNameBindings: ['className'],
+  subtitle: true,
   layout
 });
diff --git a/addon/templates/components/content-placeholders-heading.hbs b/addon/templates/components/content-placeholders-heading.hbs
@@ -3,5 +3,7 @@
 {{/if}}
 <div class="{{className}}__content">
   <div class="{{className}}__title"></div>
-  <div class="{{className}}__subtitle"></div>
+  {{#if subtitle}}
+    <div class="{{className}}__subtitle"></div>
+  {{/if}}
 </div>
diff --git a/tests/integration/components/content-placeholders-heading-test.js b/tests/integration/components/content-placeholders-heading-test.js
@@ -11,4 +11,10 @@ test('it renders', function(assert) {
 
   this.render(hbs`{{content-placeholders-heading img=true}}`);
   assert.equal(this.$('[data-test-ember-content-placeholders-heading-img]').length, 1, 'it has an img');
+
+  this.render(hbs`{{content-placeholders-heading subtitle=false}}`);
+  assert.equal(this.$('.ember-content-placeholders-heading__subtitle').length, 0, 'it has no subtitle');
+
+  this.render(hbs`{{content-placeholders-heading}}`);
+  assert.equal(this.$('.ember-content-placeholders-heading__subtitle').length, 1, 'it has a subtitle');
 });