add file:// method #512
Open
add file:// method #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue michaelrsweet#508 reports that href "file://..." is mapped to "http://remote.../file://...", which will never open in modern browsers capable of opening the "file://" method. This is a proposed fix for michaelrsweet#508. The screenshot illustrates the use case. After converting an online HTML document to PDF (using the command shown in michaelrsweet#507), open the output file in a PDF viewer, scroll down to the link in the screenshot, and click the link. Without this commit the PDF viewer, then the browser, open "http://remote.../file://...", and fail. With this commit the "file://" method is preserved, so the browser can successfully open a local file. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #508 reports that href
file://...is mapped tohttp://remote.../file://..., which will never open in modern browsers capable of opening the "file://" method.This is a proposed fix for #508.
The screenshot illustrates the use case. After converting an online HTML document to PDF (using the command shown in #507), open the output file in a PDF viewer, scroll down to the link in the screenshot, and click the link. Without this commit the PDF viewer, then the browser, open
http://remote.../file://..., and fail. With this commit the "file://" method is preserved, so the browser can successfully open a local file.