feat: removed warning when using smoloki without configured base_endp…

…oint
michaelkryukov · Aug 12, 2023 · 266142c · 266142c
1 parent 79a988a
commit 266142c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/README.md b/README.md
@@ -58,8 +58,7 @@ async function as_request_completed() {
     logged using `logging`.
 - Keys in labels and information must be strings.
 - Values in labels and information must be string, integers or floats.
-- If no `base_endpoint` provided (using parameter or env), nothing
-    will happen.
+- If no `base_endpoint` provided (using parameter or env), nothing will happen.
 
 ## Configuration
 

diff --git a/javascript/smoloki.ts b/javascript/smoloki.ts
@@ -101,7 +101,6 @@ async function push (
   const targetBaseEndpoint = baseEndpoint ?? SMOLOKI_BASE_ENDPOINT
 
   if (targetBaseEndpoint === '') {
-    console.warn("No 'base_endpoint' configured for smoloki")
     return
   }
 

diff --git a/python/smoloki/__init__.py b/python/smoloki/__init__.py
@@ -107,7 +107,6 @@ async def push(labels, information, base_endpoint=None, headers=None):
     base_endpoint = base_endpoint or SMOLOKI_BASE_ENDPOINT
 
     if not base_endpoint:
-        logging.warning("No 'base_endpoint' configured for smoloki")
         return
 
     try:
-Original file line number
+Diff line change
@@ Expand Up / @@ -101,7 +101,6 @@ async function push ( @@
       const targetBaseEndpoint = baseEndpoint ?? SMOLOKI_BASE_ENDPOINT
       if (targetBaseEndpoint === '') {
-        console.warn("No 'base_endpoint' configured for smoloki")
         return
       }
@@ Expand Down @@