Disable warning for CA1001 with disposible in TransitionHelper

See CommunityToolkit#407
michael-hawker · Mar 14, 2023 · 9b60883 · 9b60883
1 parent 9664044
commit 9b60883
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj b/components/TransitionHelper/src/CommunityToolkit.Labs.WinUI.TransitionHelper.csproj
@@ -6,6 +6,10 @@
 
     <!-- Rns suffix is required for namespaces shared across projects. See https://github.com/CommunityToolkit/Labs-Windows/issues/152 -->
     <RootNamespace>CommunityToolkit.Labs.WinUI.TransitionHelperRns</RootNamespace>
+
+    <!-- TODO: Putting here as seems to get flagged on different partials, need to deal with TokenSource being disposible -->
+    <!-- See: https://github.com/CommunityToolkit/Labs-Windows/issues/407 -->
+    <NoWarn>CA1001</NoWarn>
   </PropertyGroup>
 
   <!-- Sets this up as a toolkit component's source project -->

diff --git a/components/TransitionHelper/src/TransitionHelper.cs b/components/TransitionHelper/src/TransitionHelper.cs
@@ -10,7 +10,7 @@ namespace CommunityToolkit.Labs.WinUI;
 /// A animation helper that morphs between two controls.
 /// </summary>
 [ContentProperty(Name = nameof(Configs))]
-public sealed partial class TransitionHelper
+public sealed partial class TransitionHelper // TODO: Implement IDisposible? or resolve CA1001 another way?
 {
     private sealed record AnimatedElements<T>(
         IDictionary<string, T> ConnectedElements,