Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Function - update header and template #8

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

solid-droid
Copy link

Example:

mytable.update(["header1","header 2"],["text","checkbox"]);
mytable.reset();
mytable.loadData(data);

jquery.edittable.js Outdated Show resolved Hide resolved
jquery.edittable.js Outdated Show resolved Hide resolved
@micc83
Copy link
Owner

micc83 commented Oct 2, 2020

I've added a couple of comments. Thank you for your PR.

@micc83
Copy link
Owner

micc83 commented Oct 2, 2020

@solid-droid can you please double check. Now your PR is changing almost 400 lines of code...
image

@solid-droid
Copy link
Author

I am not sure why github is showing whole code is updated.
Even the 1st line looks the same.

@solid-droid
Copy link
Author

Check with "display the rich difference"
Its showing only a segment of the readme.md is updated
while... the "display the source difference" is showing the whole file is updated.

Copy link
Owner

@micc83 micc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is with line endings. LF (Unix) should be used while you're using CRLF (Windows).
Convert line endings back, squash your commits and you should be fine.

Nb. For the future I would suggest to check GitHub docs on line endings. Personally I would suggest using git config --global core.autocrlf true but that way you would have the same problem with your own repos.

@micc83 micc83 self-assigned this Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants