2017 ic toggle button group props dont seem to be passed down correctly to toggle button 1 #3004
+891
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1/web-components |
gd2910
force-pushed
the
2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1
branch
6 times, most recently
from
ae7c52b to
6300a05
Compare
gd2910
force-pushed
the
2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1
branch
from
22c9870 to
ca9ea5a
Compare
gd2910
force-pushed
the
2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1
branch
2 times, most recently
from
9ff5165 to
5103e9e
Compare
gd2910
force-pushed
the
2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1
branch
4 times, most recently
from
17fb6f7 to
836e244
Compare
gd2910
force-pushed
the
2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1
branch
6 times, most recently
from
471279a to
e7a7200
Compare
helper function added for a comp to detect if it is the child of a group
type added for ic-toggle-button
bugfix for ic-toggle-button-group where a slotted ic-toggle-button would flash as default then render to the required prop
gd2910
force-pushed
the
2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1
branch
from
e7a7200 to
843d9cc
Compare
tests updated after chnage in prop allocation from toggle buton group to children
gd2910
force-pushed
the
2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button-1
branch
from
843d9cc to
5ae7a78
Compare
GCHQ-Developer-299
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Bugfix: if a toggle-button (TB) slotted in a toggle-button-group (TBG) had a prop such as
loadingordisabled, the TBG would only apply the props tp the TB once it had rendered, resulting in a flash from a default TB to a TB with the required props.TB now detect whether it is a child of a TBG and applies appropriate attributes from parent.
Testing and Storybook - removed superfluous props on TB within TBG
Related issue
#2017