-
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(eslint,deps): update dependencies #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c81b814 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces a new documentation file ( Changes
Sequence Diagram(s)sequenceDiagram
participant CLI
participant UPU as UpdatePackageJson
participant Logger
participant DevDeps
CLI->>UPU: Trigger package update
UPU->>Logger: Log version bump with new package name (@mheob/eslint-config)
UPU->>DevDeps: Update devDependencies entry
DevDeps-->>UPU: Confirm update
UPU-->>CLI: Return update completion
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
Scope: all 2 workspace projects This error happened while installing a direct dependency of /tmp/eslint/packages/eslint-config Packages found in the workspace: Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pnpm-workspace.yaml (1)
9-10
: New Section Addition:onlyBuiltDependencies
The new section specifyingonlyBuiltDependencies
with the entry- esbuild
is clearly added and aligns with efforts to distinguish built dependencies from others. Ensure that your build scripts and documentation are updated accordingly to recognize this new section.packages/eslint-config/src/typegen.d.ts (1)
640-868
: Comprehensive Documentation Link UpdatesAll the
@see
documentation URLs for the ESLint import rules have been updated to reference version v4.10.3 ofeslint-plugin-import-x
. The updated links follow the expected pattern and appear consistent across the entire diff. Please verify that each URL correctly points to the updated documentation.In future, consider centralizing the documentation base URL (for example, via a constant or a common comment) to simplify version updates and reduce manual repetition.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (7)
.changeset/plain-bees-happen.md
(1 hunks)packages/eslint-config/package.json
(3 hunks)packages/eslint-config/src/cli/stages/update-package-json.ts
(1 hunks)packages/eslint-config/src/cli/versions-map.generated.ts
(1 hunks)packages/eslint-config/src/typegen.d.ts
(1 hunks)packages/eslint-config/src/utils/linting.ts
(1 hunks)pnpm-workspace.yaml
(1 hunks)
🔇 Additional comments (9)
.changeset/plain-bees-happen.md (1)
1-6
: Changeset file looks goodThis is a properly formatted changeset file documenting a patch update for the
@mheob/eslint-config
package to update dependencies.packages/eslint-config/src/cli/versions-map.generated.ts (1)
2-2
: Dependency version bump looks correctThe version of
@eslint-react/eslint-plugin
has been updated from a previous version to^1.46.0
, which aligns with the PR objective to update dependencies.packages/eslint-config/src/utils/linting.ts (1)
52-52
: Documentation example correctly updatedThe example import statement in the documentation has been updated to reference
@mheob/eslint-config
instead of the previous package name, maintaining consistency with the actual package name used in the project.packages/eslint-config/src/cli/stages/update-package-json.ts (2)
18-18
: Package name correctly updated in log messageThe log message has been updated to reference the current package name
@mheob/eslint-config
, which maintains consistency in user-facing messages.
25-25
: Package name correctly updated in devDependencies assignmentThe package name reference in the
devDependencies
object has been updated to@mheob/eslint-config
, ensuring that the correct package is added to users' package.json files.packages/eslint-config/package.json (4)
42-42
: Dependency Version Update: @eslint-community/eslint-plugin-eslint-comments
The dependency version has been updated from its previous release to^4.5.0
. Please verify that this minor upgrade does not introduce any breaking changes in your ESLint configuration or rule behavior by reviewing the plugin's changelog.
55-55
: Dependency Version Update: eslint-plugin-import-x
The version has been bumped from^4.10.2
to^4.10.3
, which aligns the dependency with the documentation link updates. Ensure that the updated rules or bug fixes in the new version do not conflict with custom settings if any.
74-74
: Dependency Version Update: svelte
The minor version update from^5.26.1
to^5.26.2
should be non-disruptive. However, it is advisable to test any Svelte components or integrations to ensure that this update does not introduce regression issues in the runtime behavior.
81-81
: Dev Dependency Version Update: @eslint-react/eslint-plugin
The dev dependency version was updated to^1.46.0
, matching the corresponding update in the CLI versions map. Confirm that the updated plugin is in sync with your ESLint rules and does not cause configuration mismatches.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @mheob/[email protected] ### Minor Changes - [#253](#253) ([@mheob](https://github.com/mheob)): add cli for initial configuration - [#249](#249) ([@mheob](https://github.com/mheob)): sync recommended rules of [react plugins](https://eslint-react.xyz/) - [#251](#251) ([@mheob](https://github.com/mheob)): allow `svelte` to overrides rules ### Patch Changes - [#254](#254) ([@mheob](https://github.com/mheob)): update dependencies ## Summary by CodeRabbit - **New Features** - Introduced a command-line tool to simplify initial ESLint configuration. - Enhanced linting support with updated recommended rules for React and added flexibility for Svelte projects. - **Maintenance** - Upgraded the ESLint configuration package to version 8.7.0 with improved dependency management.
Summary by CodeRabbit
Chores
Documentation