Skip to content

fix(eslint,deps): update dependencies #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2025
Merged

fix(eslint,deps): update dependencies #254

merged 1 commit into from
Apr 13, 2025

Conversation

mheob
Copy link
Owner

@mheob mheob commented Apr 13, 2025

Summary by CodeRabbit

  • Chores

    • Upgraded several tooling dependencies and streamlined configuration updates for improved stability and reliability.
    • Adjusted logging and dependency management settings to align with updated package naming conventions.
  • Documentation

    • Refined in-app documentation links to better reflect the current tooling versions.

@mheob mheob added dependencies Pull requests that update a dependency file eslint Belongs to ESLint config labels Apr 13, 2025
Copy link

height bot commented Apr 13, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Apr 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eslint-config ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2025 1:33pm

Copy link

changeset-bot bot commented Apr 13, 2025

🦋 Changeset detected

Latest commit: c81b814

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mheob/eslint-config Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Apr 13, 2025

Walkthrough

This pull request introduces a new documentation file (plain-bees-happen.md) that records a patch update for the @mheob/eslint-config dependency. Dependency version numbers have been bumped in the package manifest and versions map. Updates within the CLI stages adjust logging and dependency assignment to reflect the new package name, and documentation examples have been updated accordingly. Additionally, documentation links in type definitions now reference the updated version of eslint-plugin-import-x and a new onlyBuiltDependencies section has been added to the workspace configuration.

Changes

File(s) Change Summary
.changeset/plain-bees-happen.md New file documenting a patch update for dependency @mheob/eslint-config.
packages/eslint-config/package.json, packages/.../versions-map.generated.ts Updated dependency versions: bumped versions for @eslint-community/eslint-plugin-eslint-comments, eslint-plugin-import-x, svelte, and @eslint-react/eslint-plugin.
packages/eslint-config/src/cli/stages/update-package-json.ts, packages/eslint-config/src/utils/linting.ts Changed package name references from @antfu/eslint-config to @mheob/eslint-config in log messages and documentation examples.
packages/eslint-config/src/typegen.d.ts Documentation URLs for ESLint import rules now point to version 4.10.3 of eslint-plugin-import-x instead of 4.10.2.
pnpm-workspace.yaml Added a new onlyBuiltDependencies section with an entry for esbuild.

Sequence Diagram(s)

sequenceDiagram
    participant CLI
    participant UPU as UpdatePackageJson
    participant Logger
    participant DevDeps

    CLI->>UPU: Trigger package update
    UPU->>Logger: Log version bump with new package name (@mheob/eslint-config)
    UPU->>DevDeps: Update devDependencies entry
    DevDeps-->>UPU: Confirm update
    UPU-->>CLI: Return update completion
Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

Scope: all 2 workspace projects
Progress: resolved 0, reused 0, downloaded 1, added 0
/tmp/eslint/packages/eslint-config:
 ERR_PNPM_WORKSPACE_PKG_NOT_FOUND  In packages/eslint-config: "@mheob/tsconfig@workspace:*" is in the dependencies but no package named "@mheob/tsconfig" is present in the workspace

This error happened while installing a direct dependency of /tmp/eslint/packages/eslint-config

Packages found in the workspace:

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
pnpm-workspace.yaml (1)

9-10: New Section Addition: onlyBuiltDependencies
The new section specifying onlyBuiltDependencies with the entry - esbuild is clearly added and aligns with efforts to distinguish built dependencies from others. Ensure that your build scripts and documentation are updated accordingly to recognize this new section.

packages/eslint-config/src/typegen.d.ts (1)

640-868: Comprehensive Documentation Link Updates

All the @see documentation URLs for the ESLint import rules have been updated to reference version v4.10.3 of eslint-plugin-import-x. The updated links follow the expected pattern and appear consistent across the entire diff. Please verify that each URL correctly points to the updated documentation.

In future, consider centralizing the documentation base URL (for example, via a constant or a common comment) to simplify version updates and reduce manual repetition.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d20f5de and c81b814.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • .changeset/plain-bees-happen.md (1 hunks)
  • packages/eslint-config/package.json (3 hunks)
  • packages/eslint-config/src/cli/stages/update-package-json.ts (1 hunks)
  • packages/eslint-config/src/cli/versions-map.generated.ts (1 hunks)
  • packages/eslint-config/src/typegen.d.ts (1 hunks)
  • packages/eslint-config/src/utils/linting.ts (1 hunks)
  • pnpm-workspace.yaml (1 hunks)
🔇 Additional comments (9)
.changeset/plain-bees-happen.md (1)

1-6: Changeset file looks good

This is a properly formatted changeset file documenting a patch update for the @mheob/eslint-config package to update dependencies.

packages/eslint-config/src/cli/versions-map.generated.ts (1)

2-2: Dependency version bump looks correct

The version of @eslint-react/eslint-plugin has been updated from a previous version to ^1.46.0, which aligns with the PR objective to update dependencies.

packages/eslint-config/src/utils/linting.ts (1)

52-52: Documentation example correctly updated

The example import statement in the documentation has been updated to reference @mheob/eslint-config instead of the previous package name, maintaining consistency with the actual package name used in the project.

packages/eslint-config/src/cli/stages/update-package-json.ts (2)

18-18: Package name correctly updated in log message

The log message has been updated to reference the current package name @mheob/eslint-config, which maintains consistency in user-facing messages.


25-25: Package name correctly updated in devDependencies assignment

The package name reference in the devDependencies object has been updated to @mheob/eslint-config, ensuring that the correct package is added to users' package.json files.

packages/eslint-config/package.json (4)

42-42: Dependency Version Update: @eslint-community/eslint-plugin-eslint-comments
The dependency version has been updated from its previous release to ^4.5.0. Please verify that this minor upgrade does not introduce any breaking changes in your ESLint configuration or rule behavior by reviewing the plugin's changelog.


55-55: Dependency Version Update: eslint-plugin-import-x
The version has been bumped from ^4.10.2 to ^4.10.3, which aligns the dependency with the documentation link updates. Ensure that the updated rules or bug fixes in the new version do not conflict with custom settings if any.


74-74: Dependency Version Update: svelte
The minor version update from ^5.26.1 to ^5.26.2 should be non-disruptive. However, it is advisable to test any Svelte components or integrations to ensure that this update does not introduce regression issues in the runtime behavior.


81-81: Dev Dependency Version Update: @eslint-react/eslint-plugin
The dev dependency version was updated to ^1.46.0, matching the corresponding update in the CLI versions map. Confirm that the updated plugin is in sync with your ESLint rules and does not cause configuration mismatches.

@kodiakhq kodiakhq bot merged commit 4e0c437 into main Apr 13, 2025
10 checks passed
@kodiakhq kodiakhq bot deleted the update-deps branch April 13, 2025 13:36
kodiakhq bot pushed a commit that referenced this pull request Apr 13, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @mheob/[email protected]

### Minor Changes

-   [#253](#253) ([@mheob](https://github.com/mheob)): add cli for initial configuration

-   [#249](#249) ([@mheob](https://github.com/mheob)): sync recommended rules of [react plugins](https://eslint-react.xyz/)

-   [#251](#251) ([@mheob](https://github.com/mheob)): allow `svelte` to overrides rules

### Patch Changes

-   [#254](#254) ([@mheob](https://github.com/mheob)): update dependencies




## Summary by CodeRabbit

- **New Features**
  - Introduced a command-line tool to simplify initial ESLint configuration.
  - Enhanced linting support with updated recommended rules for React and added flexibility for Svelte projects.

- **Maintenance**
  - Upgraded the ESLint configuration package to version 8.7.0 with improved dependency management.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file eslint Belongs to ESLint config
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant