Skip to content

Commit

Permalink
update to send target_id [develop]
Browse files Browse the repository at this point in the history
  • Loading branch information
emma-plutoflume committed Jun 27, 2018
1 parent 0367881 commit 9fd3533
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.idea
*.pyc
*.swp

dist/
build/
Expand Down
5 changes: 3 additions & 2 deletions ecs_deploy/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,12 @@ def cron(cluster, task, rule, image, tag, command, env, role, region, access_key
print_diff(td)

new_td = create_task_definition(action, td)
role_arn = client.events.list_targets_by_rule(Rule=rule)['Targets'][0]['RoleArn']
target = client.events.list_targets_by_rule(Rule=rule)['Targets'][0]
client.update_rule(
rule=rule,
arn=new_td.arn.partition('task-definition')[0] + 'cluster/' + cluster,
role_arn=role_arn,
target_id=target['Id'],
role_arn=target['RoleArn'],
task_definition_arn=new_td.arn
)
click.secho('Updated scheduled task %s' % new_td.arn)
Expand Down
4 changes: 2 additions & 2 deletions ecs_deploy/ecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ def run_task(self, cluster, task_definition, count, started_by, overrides):
overrides=overrides
)

def update_rule(self, rule, arn, role_arn, task_definition_arn):
def update_rule(self, rule, arn, target_id, role_arn, task_definition_arn):
self.events.put_targets(
Rule=rule,
Targets=[{
'Id': '1',
'Id': target_id,
'Arn': arn,
'RoleArn': role_arn,
'EcsParameters': {'TaskDefinitionArn': task_definition_arn, 'TaskCount': 1}
Expand Down

0 comments on commit 9fd3533

Please sign in to comment.