Update load_dataframe
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
todo at some point in the future- make sure we're importing the projection constant everywhere it's used. |
bailliekova
approved these changes
Sep 20, 2024
| values: dict[Union[str, Geography], Any], | ||
| ) -> None: | ||
| """Sets the values of a column on a collection of geographies. | ||
|
|
||
| Args: | ||
| path_or_col: Short identifier for the column or a `Column` metadata object. | ||
| path: Short identifier for the column. Only this or `col` should be provided. |
There was a problem hiding this comment.
Can you update this comment about the behavior of the function when both path and col are passed?
| values: dict[Union[str, Geography], Any], | ||
| client: Optional[httpx.AsyncClient] = None, | ||
| ) -> None: | ||
| """Asynchronously sets the values of a column on a collection of geographies. | ||
|
|
||
| Args: | ||
| path_or_col: Short identifier for the column or a `Column` metadata object. | ||
| path: Short identifier for the column. Only this or `col` should be provided. |
There was a problem hiding this comment.
same as above, pls clarify behavior for different combinations of path or col provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main thing in this PR are some updates to the
load_dataframefunction. I did some major refactoring of the function and added a lot of validation to the client side so that we can narrow the scope of allowable behavior for users. I also tried to make sure that the error messages that are spat out are intelligible and give the user a hint as to how to fix whatever part of their workflow is messed up.The other small thing in this is that the
normalize_pathfunction has been updated to disallow certain substrings that can cause issues when querying the API.