Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update load_scottish #128

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Update load_scottish #128

merged 4 commits into from
Jul 3, 2024

Conversation

cdonnay
Copy link
Collaborator

@cdonnay cdonnay commented Jun 30, 2024

Since the BLT files in the scot-elex repo were edited to be true CSV files, load_scottish has been updated to account for that.

peterrrock2
peterrrock2 requested changes Jul 1, 2024
View reviewed changes
tests/test_loaders.py Outdated Show resolved Hide resolved
tests/test_loaders.py Outdated Show resolved Hide resolved
tests/test_loaders.py Show resolved Hide resolved
src/votekit/cvr_loaders.py Outdated Show resolved Hide resolved
peterrrock2
peterrrock2 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@peterrrock2 peterrrock2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@cdonnay cdonnay merged commit 2cfe619 into mggg:main Jul 3, 2024
2 checks passed
@cdonnay cdonnay deleted the update_scot branch July 3, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrrock2 peterrrock2 peterrrock2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdonnay @peterrrock2