Balance edges algos separate file #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 91.18% 90.10% -1.08%
==========================================
Files 12 13 +1
Lines 771 667 -104
==========================================
- Hits 703 601 -102
+ Misses 68 66 -2
Continue to review full report at Codecov.
|
sunnymatt
approved these changes
Dec 21, 2020
|
|
||
| *Returns* a BitSet of edges that form a mst. | ||
| """ | ||
| function random_kruskal_mst(graph::BaseGraph, |
There was a problem hiding this comment.
I like the functions being split like this! Clean and concise and easy to understand. Yay!
|
|
||
| """ Refer to test/graph.jl to see the test graph being loaded | ||
| """ | ||
|
|
There was a problem hiding this comment.
Could we also write a tiny test for the kruskal_mst method if it's not too much trouble? 😄
There was a problem hiding this comment.
of course!!! thanks for keeping me honest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The currently used balanced edge algorithm are in a new file,
balance_edges.jl.Made a corresponding test file.
Changed the name of
weighted_kruskal_mst()torandom_kruskal_mst()and made the latter take the latter generate the random weights.I introduced no new code, only renamed functions and introduced 2 new files, and moved some previously written code into them.
All of these changes are derived from #94 , but that PR is a bit too big, and has some type changes so this is the first in what I foresee about 5 small PRs that will comprise the changes in #94.