Skip to content

Commit

Permalink
Do not call deprecated eventshub.AddTracing
Browse files Browse the repository at this point in the history
  • Loading branch information
mgencur committed Aug 22, 2022
1 parent d6614b3 commit c4a276b
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion test/e2e_new/features/featuressteps/broker.go
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ func BrokerSmokeTest(brokerName, triggerName string) feature.StepFn {
feature.MakeRandomK8sName("source"),
eventshub.StartSenderToResource(broker.GVR(), brokerName),
eventshub.AddSequence,
eventshub.AddTracing,
eventshub.InputEvent(event),
),
assert.OnStore(sink).MatchEvent(eventMatchers...).Exact(1),
Expand Down
3 changes: 0 additions & 3 deletions test/e2e_new/tracing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func TracingHeadersUsingOrderedDeliveryWithTraceExported() *feature.Feature {
sourceName,
eventshub.StartSenderToResource(broker.GVR(), brokerName),
eventshub.InputEvent(ev),
eventshub.AddTracing,
// Send at least two events to workaround https://github.com/knative/pkg/issues/2475.
// There's some time needed for exporting the trace to Zipkin. Sending two events with
// some delay gives the exporter time to export the trace for the first event. The sender
Expand Down Expand Up @@ -225,7 +224,6 @@ func TracingHeadersUsingUnorderedDelivery() *feature.Feature {
sourceName,
eventshub.StartSenderToResource(broker.GVR(), brokerName),
eventshub.InputEvent(ev),
eventshub.AddTracing,
))

f.Assert("received event has traceparent header",
Expand Down Expand Up @@ -276,7 +274,6 @@ func TracingHeadersUsingUnorderedDeliveryWithMultipleTriggers() *feature.Feature
sourceName,
eventshub.StartSenderToResource(broker.GVR(), brokerName),
eventshub.InputEvent(ev),
eventshub.AddTracing,
eventshub.SendMultipleEvents(5, time.Millisecond),
))

Expand Down
1 change: 0 additions & 1 deletion test/e2e_new_channel/tracing_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ func eventWithTraceExported() *feature.Feature {
sourceName,
eventshub.StartSenderToResource(channel_impl.GVR(), channelName),
eventshub.InputEvent(ev),
eventshub.AddTracing,
// Send at least two events to workaround https://github.com/knative/pkg/issues/2475.
// There's some time needed for exporting the trace to Zipkin. Sending two events with
// some delay gives the exporter time to export the trace for the first event. The sender
Expand Down

0 comments on commit c4a276b

Please sign in to comment.