Stop terminating "attached" debugees when exiting Vim #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think it should be okay to make this change.
At least I currently can't think of a scenario where this would leak a process also created by nvim-dap, but I may be missing something obvious.
In any case, maybe worth a try. If somebody complains it can still be reverted.
(And in that case, you could try adding a QuitPre autocommand that disconnects. If by the time ExitPre fires the session is already gone, nvim-dap won't terminate it)
mfussenegger
force-pushed
the
disconnect-on-vim-exit
branch
from
96a2026
to
b374cbe
Compare
When attaching to an already running process, you typically want to
temporarily inspect the process, but you do not want to manage the
process' lifetime. The exit callback currently terminates all sessions
and their debugees.
autocmd ExitPre * lua require('dap')._vim_exit_handler()
This commit changes the exit handler such that it disconnects from
"attached" debugees without terminating them.
Co-authored-by: Mathias Fußenegger <[email protected]>
mfussenegger
force-pushed
the
disconnect-on-vim-exit
branch
from
b374cbe
to
c9e86d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I mostly use DAP to debug a long-running server process. My workflow has me closing Vim frequently, and whenever I do without remembering to disconnect the debugger, I accidentally terminate the server. Is that intended behavior? Why would DAP want to manage the lifecycle of an "attached" debugee?
Anyways, this hack seems to fix it for me. This was the smallest change I could think of, but it's a breaking change. Perhaps it would be better placed as a per configuration option (
terminate_on_vim_exit = falseoron_vim_exit = "terminate" | "disconnect"), which defaults to termination, but allows opting out?I'm not particularly attached to any of this. Take it or leave it, or modify it as you see fit :)
Thanks for your work on this plugin 👍